Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node-sqlite3 connector #3032

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: node-sqlite3 connector #3032

wants to merge 3 commits into from

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Create a new database connector with node-sqlite3 to use in the WebContainer environment and allow running Nuxt Content in Stackblitz

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

Deploying content with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: d896480
Status:Β βœ…Β  Deploy successful!
Preview URL: https://a41d66c9.content-f0q.pages.dev
Branch Preview URL: https://feat-sqlite3.content-f0q.pages.dev

View logs

Copy link

pkg-pr-new bot commented Jan 24, 2025

npm i https://pkg.pr.new/@nuxt/content@3032

commit: d896480

@pi0
Copy link
Member

pi0 commented Jan 24, 2025

Couldn't this be a PR to db0?

@farnabaz
Copy link
Member Author

Couldn't this be a PR to db0?

@pi0 node-sqlite3 is not listed in unjs/db0#32 and I didn't want to disturb you with unwanted PR

@pi0
Copy link
Member

pi0 commented Jan 24, 2025

it is certainly not disturbing! (please consider reporting issues and new driver requirements upstream so we can keep supporting them more stably) -- BTW I am also thinking to use it for nitro repo fixtures better-sqlite3 often has node dep issues.

Feel free to drop a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants