Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node-sqlite3 connector #147

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Conversation

farnabaz
Copy link
Contributor

@farnabaz farnabaz commented Jan 24, 2025

Implement a new connector for the node-sqlite3 package.

Discussed in nuxt/content#3032 (comment)

I renamed docs/2.connectors/sqlite.md to docs/2.connectors/better-sqlite3.md in order to create another file for the new connector. We need to redirect the old path to the new one.

@pi0
Copy link
Member

pi0 commented Jan 24, 2025

Do you mind to update tests as well?

Also considering their similarities, I would keep both under same page 2 sections for alternatives (we could also do a small compare)

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 61.84211% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@37d2d3c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/connectors/node-sqlite3.ts 61.84% 29 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage        ?   41.18%           
=======================================
  Files           ?       22           
  Lines           ?      828           
  Branches        ?       83           
=======================================
  Hits            ?      341           
  Misses          ?      481           
  Partials        ?        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farnabaz
Copy link
Contributor Author

I'm not sure about the compare section. Can you take care of it? 🙏

@pi0 pi0 changed the title feat(connectors): node-sqlite3 connector feat: add node-sqlite3 connector Jan 24, 2025
@pi0
Copy link
Member

pi0 commented Jan 24, 2025

(tests are good, CI is buggy with npm rate limits)

@pi0 pi0 merged commit 54e81ed into unjs:main Jan 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants