Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update panic error handling in containers #173

Merged
merged 10 commits into from
Feb 4, 2025
Merged

chore: update panic error handling in containers #173

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
147eb7a
chore: update error handling to include panic error message in source…
adarsh0728 Jan 25, 2025
da42e80
fix: unit test -- TestService_SourceTransformFn_Panic
adarsh0728 Jan 27, 2025
43d37a5
gRPC error code changes & added prefix in caseof handleRequest panics
adarsh0728 Jan 27, 2025
f93025d
revert: handle panic cases only in this pr
adarsh0728 Jan 28, 2025
c6ae6bc
source and sink changes
adarsh0728 Jan 28, 2025
e93fdf3
map and map stream error handling
adarsh0728 Jan 28, 2025
3277ee2
handle panic errors and fix tests
adarsh0728 Jan 29, 2025
f3fc30e
add debug stack to err log
adarsh0728 Jan 31, 2025
b6e0fe8
fix tests
adarsh0728 Jan 31, 2025
074bb1f
added debug stack in details (debug info) of gRPC status
adarsh0728 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/sourcetransformer/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ outer:
if err := grp.Wait(); err != nil {
log.Printf("Stopping the SourceTransformFn with err, %s", err)
fs.shutdownCh <- struct{}{}
return status.Errorf(codes.Internal, err.Error())
return status.Errorf(codes.Internal, "%s", err.Error())
}

// check if there was an error while reading from the stream
if readErr != nil {
return status.Errorf(codes.Internal, readErr.Error())
return status.Errorf(codes.Internal, "%s", readErr.Error())
}
return nil
}
Expand Down Expand Up @@ -158,7 +158,7 @@ func (fs *Service) handleRequest(ctx context.Context, req *v1.SourceTransformReq
defer func() {
if r := recover(); r != nil {
log.Printf("panic inside handler: %v %v", r, string(debug.Stack()))
err = errTransformerPanic
err = fmt.Errorf("%s: %v", errTransformerPanic, r)
}
}()

Expand Down
Loading