chore: update panic error handling in containers #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transformer Signed-off-by: adarsh0728 <[email protected]>
KeranYang
reviewed
Jan 26, 2025
yes! forgot to convert it into draft :) |
Signed-off-by: adarsh0728 <[email protected]>
adarsh0728
changed the title
Signed-off-by: adarsh0728 <[email protected]>
adarsh0728
changed the title
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
vigith
reviewed
Jan 29, 2025
KeranYang
approved these changes
Jan 29, 2025
|
Please return the stack trace along with the error message, in future when we want to show errors in the UI, stack traces will help. |
Signed-off-by: adarsh0728 <[email protected]>
Signed-off-by: adarsh0728 <[email protected]>
adarsh0728
requested review from
yhl25
and removed request for
yhl25 and
whynowy
Signed-off-by: adarsh0728 <[email protected]>
yhl25
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prefix
UDF_EXECUTION_ERRORin panic mssgs in all containers to use it across SDK's to formalize error from user's code. This will help in debuggability and distinguishing between error in platform and user code.Fixed error handling in case of sideInput, sourceTransformer
Error handling In case of reducer, sessionReducer, reduceStreamer (we are not sending error back in case of panics) to be taken up in separate PR.
Added debug stack in details part which represents a serialized
google.rpc.Status, the bytes should be parsed as a Protobuf message at client side.fixes #174