Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support headers for message #108

Merged
merged 5 commits into from
Mar 21, 2024
Merged

feat: support headers for message #108

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a91b98f
support headers for message
yhl25 Mar 19, 2024
bf841dd
update tests
yhl25 Mar 19, 2024
b8d8374
source transformer
yhl25 Mar 21, 2024
716be4a
update makefile
yhl25 Mar 21, 2024
a32faff
review comments
yhl25 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,9 @@ proto:
generate:
go generate ./...

.PHONY: image-push-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayildirim21 please review this makefile target and see if this is something we already worked on as part of the CI improvement task or something we can leverage to simplify our CI script.

Copy link
Member

@ayildirim21 ayildirim21 Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confrim that the existing script already implements this functionality, just need to run:

./hack/update_examples.sh -bp

Will open a PR to remove this makefile target.

Edit: #109

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not remove the target, instead let the target run ./hack/update_examples -bp

image-push-all:
for dir in $(shell find ./pkg -name 'Makefile' -exec dirname {} \;); do \
$(MAKE) -C $$dir image-push TAG=$(TAG); \
done

106 changes: 62 additions & 44 deletions pkg/apis/proto/map/v1/map.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/apis/proto/map/v1/map.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ message MapRequest {
bytes value = 2;
google.protobuf.Timestamp event_time = 3;
google.protobuf.Timestamp watermark = 4;
map<string, string> headers = 5;
}

/**
Expand Down
Loading
Loading