feat: support headers for message #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
KeranYang
reviewed
Mar 21, 2024
| @@ -16,4 +16,9 @@ proto: | |||
| generate: | |||
| go generate ./... | |||
|
|
|||
| .PHONY: image-push-all | |||
There was a problem hiding this comment.
@ayildirim21 please review this makefile target and see if this is something we already worked on as part of the CI improvement task or something we can leverage to simplify our CI script.
There was a problem hiding this comment.
Can confrim that the existing script already implements this functionality, just need to run:
./hack/update_examples.sh -bp
Will open a PR to remove this makefile target.
Edit: #109
There was a problem hiding this comment.
please do not remove the target, instead let the target run ./hack/update_examples -bp
pkg/reducer/task_manager.go
Outdated
| @@ -166,5 +166,5 @@ func generateKey(window *v1.Window, keys []string) string { | |||
| } | |||
|
|
|||
| func buildDatum(request *v1.ReduceRequest) Datum { | |||
| return NewHandlerDatum(request.Payload.GetValue(), request.Payload.EventTime.AsTime(), request.Payload.Watermark.AsTime()) | |||
| return NewHandlerDatum(request.Payload.GetValue(), request.Payload.EventTime.AsTime(), request.Payload.Watermark.AsTime(), request.Payload.Headers) | |||
There was a problem hiding this comment.
GetEventTime, GetWatermark, GetHeaders - same for below
Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes numaproj/numaflow#1586