Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/_http_outgoing.js
Original file line number Diff line number Diff line change
Expand Up @@ -673,20 +673,22 @@ OutgoingMessage.prototype.setHeaders = function setHeaders(headers) {
// We also cannot safely split by comma.
// To avoid setHeader overwriting the previous value we push
// set-cookie values in array and set them all at once.
const cookies = [];
let cookies = null;

for (const { 0: key, 1: value } of headers) {
if (key === 'set-cookie') {
if (ArrayIsArray(value)) {
cookies ??= [];
cookies.push(...value);
} else {
cookies ??= [];
Comment on lines 680 to +684
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (ArrayIsArray(value)) {
cookies ??= [];
cookies.push(...value);
} else {
cookies ??= [];
cookies ??= [];
if (ArrayIsArray(value)) {
cookies.push(...value);
} else {

cookies.push(value);
}
continue;
}
this.setHeader(key, value);
}
if (cookies.length) {
if (cookies != null) {
this.setHeader('set-cookie', cookies);
}

Expand Down
Loading