http: lazy allocate cookies array #59734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
juanarbol
approved these changes
Sep 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59734 +/- ##
==========================================
- Coverage 89.95% 89.93% -0.02%
==========================================
Files 667 667
Lines 196776 196778 +2
Branches 38409 38417 +8
==========================================
- Hits 177006 176977 -29
- Misses 12198 12211 +13
- Partials 7572 7590 +18
🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
Sep 2, 2025
pimterry
approved these changes
Sep 2, 2025
pimterry
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Sep 3, 2025
jakecastelli
approved these changes
Sep 3, 2025
gurgunday
approved these changes
Sep 3, 2025
BridgeAR
approved these changes
Sep 3, 2025
Comment on lines
680
to
+684
| if (ArrayIsArray(value)) { | ||
| cookies ??= []; | ||
| cookies.push(...value); | ||
| } else { | ||
| cookies ??= []; |
There was a problem hiding this comment.
Suggested change
| if (ArrayIsArray(value)) { | |
| cookies ??= []; | |
| cookies.push(...value); | |
| } else { | |
| cookies ??= []; | |
| cookies ??= []; | |
| if (ArrayIsArray(value)) { | |
| cookies.push(...value); | |
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.