Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open utility classes for external consumption. #202

Merged
merged 4 commits into from
Dec 11, 2021
Merged

Open utility classes for external consumption. #202

merged 4 commits into from
Dec 11, 2021

Conversation

deepy
Copy link
Member

@deepy deepy commented Oct 22, 2021 •
edited
Loading

Make the ExecRunners (and depending classes) public to allow for external users to use these to extend functionality.

This is the simpler solution compared to subclassing the tasks

@deepy deepy marked this pull request as draft October 22, 2021 08:40
This was referenced Oct 22, 2021
Open
Closed
@pun-ky pun-ky mentioned this pull request Nov 24, 2021
Open
@pun-ky
Copy link

pun-ky commented Nov 24, 2021

please open https://github.com/node-gradle/gradle-node-plugin/blob/master/src/main/kotlin/com/github/gradle/node/yarn/exec/YarnExecRunner.kt too ;) thx

@pun-ky pun-ky mentioned this pull request Nov 24, 2021
Open
@deepy deepy changed the title WIP: Open utility classes for external consumption. Open utility classes for external consumption. Dec 9, 2021
@deepy
Copy link
Member Author

deepy commented Dec 9, 2021

Did the tests just fail because the npm version increased?

@deepy deepy marked this pull request as ready for review December 11, 2021 11:44
@deepy deepy merged commit e4b9b15 into master Dec 11, 2021
@deepy deepy deleted the open-util-classes branch December 11, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepy @pun-ky