Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent plugin incompatibility when upgrading to 3.x #203

Open
pun-ky opened this issue Nov 24, 2021 · 3 comments
Open

Dependent plugin incompatibility when upgrading to 3.x #203

pun-ky opened this issue Nov 24, 2021 · 3 comments

Comments

@pun-ky
Copy link

pun-ky commented Nov 24, 2021

Hey! Thx for the updates in 3.x.

However, now I see the problem when I am trying to upgrade Gradle Lighthouse Plugin which I am maintaining.
Previously I was able to instantiate YarnExecRunner by myself to be able to execute it multiple times within single task execution (just using YarnTask does not make it possible).
Right now due to internal here - https://github.com/wttech/gradle-lighthouse-plugin/blob/master/src/main/kotlin/com/cognifide/gradle/lighthouse/runner/Runner.kt#L53 I am not able to instantiate it.

Could you consider not having internal here to unblock me in upgrading my plugin?
Could you release it after making the change?

@pun-ky
Copy link
Author

pun-ky commented Nov 24, 2021

my problem is conceptually similar to #202

@deepy
Copy link
Member

deepy commented Dec 7, 2021

YarnExecRunner is on the list of things to be opened, but I've had limited time and not been able to work through all of it yet

The work is being tracked in #190, but if you could confirm if you need any of the private functions in YarnExecRunner that'd be great and speed up the work :-)
I think the API has changed a bit now that it's abstract, one easy way to test would be to clone the branch from #202, open up YarnExecRunner and see if your plugins builds using a composite build

@deepy
Copy link
Member

deepy commented Dec 9, 2021

@pun-ky I've looked at lighthouse/runner/Runner.kt#L55 and the API has changed from 2.x

You probably want to do pretty much the same thing as YarnTask's exec method.

I haven't thought all too much about the API, but I don't think the FooExecs will go all the way to open, they'll be public and the way to go is probably changing what they're given, in your case I think that'll just setting the values of NodeExecConfiguration is good enough, but for others I suspect extending the VariantComputer will be good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants