Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helm package oci registry support #1282

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added helm package oci registry support #1282

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65bad5
Added helm package oci registry support
Jan 11, 2025
94df5a8
cleaned go jobs and fixed registry repo
Jan 25, 2025
7614a4c
added chart metadata
Jan 30, 2025
fc846f1
added documantation for helm deployment
Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ on:
- release-0.64
- release-0.52
- release-0.47
env:
HELM_REGISTRY: ghcr.io
CHART_DIR: deploy/helm
jobs:
release:
runs-on: ubuntu-latest
Expand All @@ -43,3 +46,19 @@ jobs:
uses: actions-ecosystem/action-push-tag@v1
with:
tag: ${{ steps.bump-semver.outputs.new_version }}
- name: Install Helm
uses: azure/setup-helm@v4
env:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
- name: Log into registry ${{ env.REGISTRY }}
uses: docker/login-action@28218f9b04b4f3f62068d7b6ce6ca5b26e35336c
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Template Helm charts
run: |
make manifests
helm dependency update ./${{ env.CHART_DIR }}
helm package ./${{ env.CHART_DIR }} --destination ./charts --app-version ${{ steps.bump-semver.outputs.new_version }} --version ${{ steps.bump-semver.outputs.new_version }}
supu2 marked this conversation as resolved.
Show resolved Hide resolved
helm push ./charts/${{ github.event.repository.name }}-${{ steps.bump-semver.outputs.new_version }}.tgz oci://${{ env.HELM_REGISTRY }}/${{ github.repository_owner }}/${{ github.event.repository.name }}
6 changes: 6 additions & 0 deletions deploy/helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of nits for the manifest. If we are going to build&push it to the public, let's have metadata complete.

Comparing with e.g. https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/Chart.yaml and looking at our current https://github.com/nmstate/kubernetes-nmstate/blob/main/deploy/bases/kubernetes-nmstate-operator.clusterserviceversion.yaml, what we can easily add is

  • home
  • icon
  • keywords
  • kubeVersion
  • maintainers
  • sources

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkowalski updated chart file. I'm not sure kubeversion support I hope nmstate works on 1.21.0

name: kubernetes-nmstate
description: Declarative node network configuration driven through Kubernetes API.
type: application
version: 0.1.0
supu2 marked this conversation as resolved.
Show resolved Hide resolved
appVersion: "1.16.0"
supu2 marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions deploy/helm/crds
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../crds
1 change: 1 addition & 0 deletions deploy/helm/templates/nmstate.io_v1_nmstate_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../../build/_output/manifests/nmstate.io_v1_nmstate_cr.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are all dangling symlinks, i.e. when you just git clone they will not point to existing files, not even to the directory structure.

I would rather keep deploy/ in the repository clean and have something like

mkdir -p deploy/helm/templates
cp ../../../build/_output/manifests/* deploy/helm/templates/

inside the pipeline, so after make manifests.

1 change: 1 addition & 0 deletions deploy/helm/templates/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../../build/_output/manifests/operator.yaml
1 change: 1 addition & 0 deletions deploy/helm/templates/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../../build/_output/manifests/role.yaml
1 change: 1 addition & 0 deletions deploy/helm/templates/role_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../../build/_output/manifests/role_binding.yaml
1 change: 1 addition & 0 deletions deploy/helm/templates/service_account.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../../build/_output/manifests/service_account.yaml
Empty file added deploy/helm/values.yaml
View file
Open in desktop
Empty file.