Added helm package oci registry support #1282
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubevirt-bot
added
dco-signoff: no
|
Hi @supu2. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
.github/workflows/release.yml
Outdated
| - name: Setup Go 1.21.x | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.21.x' |
There was a problem hiding this comment.
Can you install the go version from go.mod ?
.github/workflows/release.yml
Outdated
| make manifests | ||
| helm dependency update ./${{ env.CHART_DIR }} | ||
| helm package ./${{ env.CHART_DIR }} --destination ./charts --app-version ${{ steps.bump-semver.outputs.new_version }} --version ${{ steps.bump-semver.outputs.new_version }} | ||
| helm push ./charts/${{ github.event.repository.name }}-${{ steps.bump-semver.outputs.new_version }}.tgz oci://ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }} |
There was a problem hiding this comment.
| helm push ./charts/${{ github.event.repository.name }}-${{ steps.bump-semver.outputs.new_version }}.tgz oci://ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }} | |
| helm push ./charts/${{ github.event.repository.name }}-${{ steps.bump-semver.outputs.new_version }}.tgz oci://${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ github.event.repository.name }} |
.github/workflows/release.yml
Outdated
| @@ -21,6 +21,9 @@ on: | |||
| - release-0.64 | |||
| - release-0.52 | |||
| - release-0.47 | |||
| env: | |||
| REGISTRY: ghcr.io | |||
There was a problem hiding this comment.
this is for Helms repository not for kubernetes-nmstate containers.
| REGISTRY: ghcr.io | |
| HELM_REGISTRY: ghcr.io |
Signed-off-by: Supu <[email protected]>
Signed-off-by: Supu <[email protected]>
kubevirt-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
dco-signoff: no
| @@ -0,0 +1,6 @@ | |||
| apiVersion: v2 | |||
There was a problem hiding this comment.
A bunch of nits for the manifest. If we are going to build&push it to the public, let's have metadata complete.
Comparing with e.g. https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/Chart.yaml and looking at our current https://github.com/nmstate/kubernetes-nmstate/blob/main/deploy/bases/kubernetes-nmstate-operator.clusterserviceversion.yaml, what we can easily add is
- home
- icon
- keywords
- kubeVersion
- maintainers
- sources
There was a problem hiding this comment.
@mkowalski updated chart file. I'm not sure kubeversion support I hope nmstate works on 1.21.0
Signed-off-by: Supu <[email protected]>
kubevirt-bot
added
dco-signoff: yes
Signed-off-by: Supu <[email protected]>
| maintainers: | ||
| - email: [email protected] | ||
| name: Enrique Llorente Pastora | ||
| - email: [email protected] |
There was a problem hiding this comment.
@mkowalski would you mind if you were listed instead of me? It would better reflect the reality
There was a problem hiding this comment.
This will happen. It's just that it's not the only place where we should remove you (e.g. there is also the OLM manifest) so I would merge this one as-is and then I will handle the metadata update myself
| @@ -0,0 +1 @@ | |||
| ../../../build/_output/manifests/nmstate.io_v1_nmstate_cr.yaml | |||
There was a problem hiding this comment.
Those are all dangling symlinks, i.e. when you just git clone they will not point to existing files, not even to the directory structure.
I would rather keep deploy/ in the repository clean and have something like
mkdir -p deploy/helm/templates
cp ../../../build/_output/manifests/* deploy/helm/templates/
inside the pipeline, so after make manifests.
Is this a BUG FIX or a FEATURE ?:
I've added helm package and oci registry support. People who don't want to use olm they can use helm.
/kind enhancement