Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust-analyzer): use pname in call to buildVscodeExtension #182

Closed
wants to merge 1 commit into from

Conversation

dustypomerleau
Copy link

Thanks for all your hard work on Fenix.

rust-analyzer builds broke for me shortly after NixOS/nixpkgs#354740 was merged.

 … from call site
         at /nix/store/bd5j75vv19g3q0ijgi4plvfwsb95648d-source/default.nix:190:5:
          189|     in
          190|     pkgs.vscode-utils.buildVscodeExtension {
             |     ^
          191|       name = "rust-analyzer-${rust-analyzer-rev}";

       error: function 'buildVscodeExtension' called without required argument 'pname'
       at /nix/store/sp3c1kqpv8lnzi9njdly8ig00gg9c3p8-source/pkgs/applications/editors/vscode/extensions/vscode-utils.nix:13:5:
           12|   buildVscodeExtension =
           13|     a@{
             |     ^
           14|       pname,

This PR works for me locally by passing pname instead of name. Please let me know if anything else needs to be done.

 - system: `"aarch64-darwin"`
 - host os: `Darwin 24.1.0, macOS 15.1.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Lix, like Nix) 2.91.1

@dustypomerleau
Copy link
Author

Ah, sorry, it looks like this is a duplicate of #180. But in 180 the additional interpolation ${rust-analyzer-rev} has been removed—I assume it should be left in place? Happy for this to be closed if 180 is being merged.

Comment on lines +191 to 192
pname = "rust-analyzer-${rust-analyzer-rev}";
version = rust-analyzer-rev;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the rev here is definitely wrong as it will be duplicated in the final name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I'll close this, in any event, as it appears #184 is passing CI.

@dustypomerleau dustypomerleau deleted the pname branch December 1, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants