fix: pass both name and pname to buildVscodeExtension

[Defelo]

Supersedes #180 and #182

Sorry for creating a third PR on this, however I really would like this issue to be solved as quickly as possible as it is currently blocking stable 1.83.0 from being merged into main.

As suggested in #180 (comment) we could also try to detect which argument the function expects and pass the correct one, but I think just passing both arguments should be the simplest solution. Please let me know if there are any disadvantages to this approach.

[SuperSandro2000]

Passing name and pname with different content is definitely not a good solution.

[Defelo]

Passing name and pname with different content is definitely not a good solution.

Ok, could you explain why? If name is not set shouldn't it just default to "${pname}-${version}" (which in this case is exactly the same as the name we have here)? Which solution would you prefer?

[Sciencentistguy]

Defelo is right, previously name was just set to what is naturally produced by mkDerivation when pname and version are both present. so there's no change there

[srounce]

Passing name and pname with different content is definitely not a good solution.

If you have a better one please feel free to share it, currently this is blocking projects from using latest nixpkgs so it'd be great to get this back to a working state in some way or other and then improve on it later.

[bryango]

I am trying to fix this upstream at NixOS/nixpkgs#361052 as this also affects other projects.

[domenkozar]

Fixed in nixpkgs!