Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@hsorby
Copy link
Contributor

@hsorby hsorby commented Aug 25, 2021

Description

Change the view in full screen button to open the image in the Biolucida viewer application.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Using the relative link: datasets/biolucidaviewer/2720?view=MjcyMC1jb2wtMTA4&dataset_version=5&dataset_id=43&item_id=N%3Apackage%3A7d2541f3-32ca-402b-9685-aaac8a4c9732

Clicking the 'View in 3D' button:

image

Will open the Biolucida viewer application if you have it or direct you to a page for next steps if you don't.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

dependabot bot and others added 10 commits August 24, 2021 00:21
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.3 to 4.16.8.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.16.3...4.16.8)

---
updated-dependencies:
- dependency-name: browserslist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [striptags](https://github.com/ericnorris/striptags) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/ericnorris/striptags/releases)
- [Commits](ericnorris/striptags@v3.1.1...v3.2.0)

---
updated-dependencies:
- dependency-name: striptags
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…com:nih-sparc/sparc-app into biolucida-viewer
@hsorby hsorby requested review from Tehsurfer and alan-wu August 25, 2021 00:07
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nickerso nickerso marked this pull request as draft August 25, 2021 03:32
Copy link
Contributor

@Tehsurfer Tehsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gallery doesn't seem to show on dateset 43?
image

When I go to the given link for testing, I get the following error:
image

Is there something I'm missing to be able to test this?

@hsorby
Copy link
Contributor Author

hsorby commented Aug 26, 2021

I think @Tehsurfer I would suggest that things are not setup correctly. The given link is a relative link for the segmentation viewer. The link you have posted is for localhost, for that to work you would have to use the branches in both sparc-app and sparc-api and fully build the application.

I don't know where you posted that image from showing no image gallery for dataset 43. That makes it hard to understand why it might not be working. On all the websites that have been setup with this functionality the image gallery is present for this dataset.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants