Skip to content

Update n1c labels the new required ones #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update n1c labels the new required ones #7966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/nginx/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,10 +634,10 @@
fmt.Sprintf("product-type=%s", metadataInfo.ProductType),
fmt.Sprintf("product-version=%s", metadataInfo.ProductVersion),
fmt.Sprintf("cluster-id=%s", metadataInfo.ClusterID),
fmt.Sprintf("installation-name=%s", metadataInfo.InstallationName),
fmt.Sprintf("installation-id=%s", metadataInfo.InstallationID),
fmt.Sprintf("control-name=%s", metadataInfo.InstallationName),

Check warning on line 638 in internal/nginx/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/nginx/manager.go#L638 

Added line #L638 was not covered by tests
fmt.Sprintf("control-id=%s", metadataInfo.InstallationID), // control-id is required but is the same as installation-id
fmt.Sprintf("installation-namespace=%s", metadataInfo.InstallationNamespace),
fmt.Sprintf("control-namespace=%s", metadataInfo.InstallationNamespace),

Check warning on line 640 in internal/nginx/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/nginx/manager.go#L640 

Added line #L640 was not covered by tests
}
metadataLabels := "--labels=" + strings.Join(labels, ",")
args = append(args, metadataLabels)
Expand Down
Loading