Skip to content

Update n1c labels the new required ones #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

Update n1c labels the new required ones

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner June 26, 2025 14:35
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Jun 26, 2025
@AlexFenlon AlexFenlon added the needs cherry pick Cherry pick this PR into a release branch label Jun 26, 2025
@AlexFenlon AlexFenlon marked this pull request as draft June 26, 2025 14:37
Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that's the correct label to use per n1c

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.93%. Comparing base (269f924) to head (1383dac).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7966   +/-   ##
=======================================
  Coverage   52.93%   52.93%           
=======================================
  Files          90       90           
  Lines       21729    21729           
=======================================
  Hits        11502    11502           
  Misses       9748     9748           
  Partials      479      479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexFenlon AlexFenlon closed this Jun 27, 2025
@AlexFenlon
Copy link
Contributor Author

no longer required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants