Open
Conversation
maxulysse
reviewed
Mar 3, 2026
PeterKneale
reviewed
Mar 3, 2026
| """ | ||
| get_seqs \\ | ||
| $args \\ | ||
| -e $bed \\ |
Contributor
Contributor
Author
There was a problem hiding this comment.
Yes, that's probably a good idea
Contributor
Author
There was a problem hiding this comment.
OK, fixed. I explicitly check if task.ext.args is a string, and if so we use it even if it's empty. Otherwise we fall back to -e, catching the case where it is unset and thus null.
Contributor
Author
|
@nf-core-bot fix linting |
prototaxites
commented
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Noticed a couple of little points for purge_dups that could be fixed:
-eoption, which is not necessary for operation. This removes this in favour of allowing its specification in$args.${}cause it's prettier :)PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda