update CADD version to 1.7.3#10290
Merged
ramprasadn merged 10 commits intonf-core:masterfrom Mar 3, 2026
Merged
Conversation
FriederikeHanssen
approved these changes
Mar 3, 2026
fellen31
reviewed
Mar 3, 2026
| ['singularity', 'apptainer'].contains(workflow.containerEngine) ? | ||
| "-B ${annotation_dir}:/opt/CADD-scripts-1.6.post1/data/annotations" : | ||
| "-v ${annotation_dir}:/opt/CADD-scripts-1.6.post1/data/annotations" }" | ||
| container 'docker.io/clinicalgenomics/cadd-with-scripts:1.7.3' |
Contributor
There was a problem hiding this comment.
Was there an issue with the official docker://visze/cadd-scripts-v1_7:0.1.1?
Contributor
Author
There was a problem hiding this comment.
Yeah, that only contains the environments, not the actual CADD-scripts package.
Contributor
Author
|
Updated the container to incorporate @mashehu's comments from https://nfcore.slack.com/archives/CJRH30T6V/p1772367520618609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda