Skip to content

adding kmergenie module#10281

Merged
LiaOb21 merged 7 commits intonf-core:masterfrom
LiaOb21:kmergenie
Mar 3, 2026
Merged

adding kmergenie module#10281
LiaOb21 merged 7 commits intonf-core:masterfrom
LiaOb21:kmergenie

Conversation

@LiaOb21
Copy link
Contributor

@LiaOb21 LiaOb21 commented Feb 27, 2026

Hello!

This PR is to create a new nf-core module for kmergenie.

PR checklist

Closes #10269

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@chriswyatt1 chriswyatt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this all looks great to me.
Let's get this merged, if you have tested in your pipeline and it works as expected.

@chriswyatt1
Copy link
Contributor

Meant to add that the tests look good. They work as expected 👍

Copy link
Contributor

@FernandoDuarteF FernandoDuarteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test works as expected, and I don't see any major issues.

Just added a few comments that you can probably disregard, so I'll just approve it.

LiaOb21 and others added 4 commits March 3, 2026 10:14
correcting spaces

Co-authored-by: Chris Wyatt <9978862+chriswyatt1@users.noreply.github.com>
keeping only histo and pdf in stub
Adding back files to stub
@LiaOb21 LiaOb21 added this pull request to the merge queue Mar 3, 2026
Merged via the queue into nf-core:master with commit 0d81214 Mar 3, 2026
22 checks passed
@LiaOb21 LiaOb21 deleted the kmergenie branch March 3, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: KMERGENIE

3 participants