Skip to content

chore(modules): migrate adapterremoval & adapterremovalfixprefix to new version output format#10266

Open
maxcumminsandfred-lab wants to merge 17 commits intonf-core:masterfrom
maxcumminsandfred-lab:migrate-versions-adapterremoval
Open

chore(modules): migrate adapterremoval & adapterremovalfixprefix to new version output format#10266
maxcumminsandfred-lab wants to merge 17 commits intonf-core:masterfrom
maxcumminsandfred-lab:migrate-versions-adapterremoval

Conversation

@maxcumminsandfred-lab
Copy link
Contributor

@maxcumminsandfred-lab maxcumminsandfred-lab commented Feb 25, 2026

Migrated module to use topic channels for version outputs.

Generated by nfcore-migrate-versions skill (ClawHub pending).

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

maxcumminsandfred and others added 4 commits February 25, 2026 21:22
Migrated module to use topic channels for version outputs.

Files changed:
- modules/nf-core/adapterremoval/main.nf
- modules/nf-core/adapterremoval/meta.yml
- modules/nf-core/adapterremoval/tests/main.nf.test
- modules/nf-core/adapterremoval/tests/main.nf.test.snap

Generated by nfcore-migrate-versions skill (ClawHub pending).
@maxcumminsandfred-lab maxcumminsandfred-lab changed the title Migrate versions adapterremoval chore(modules): migrate adapterremoval to new version output format Feb 25, 2026
@maxcumminsandfred-lab maxcumminsandfred-lab changed the title chore(modules): migrate adapterremoval to new version output format chore(modules): migrate adapterremoval & adapterremovalfixprefix to new version output format Feb 26, 2026
{ assert snapshot(
process.out,
path(process.out.versions[0]).yaml
process.out.findAll { key, val -> key.startsWith('versions') }[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this when you have the whole of process.out

@mashehu
Copy link
Contributor

mashehu commented Mar 3, 2026

Just a general note: could you mark this account clearer as a bot account (e.g. adding it as a github app to get the correct label or at least adding [bot] to the username.

maxcumminsandfred-lab and others added 2 commits March 3, 2026 13:22
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@maxcumminsandfred-lab
Copy link
Contributor Author

Just a general note: could you mark this account clearer as a bot account (e.g. adding it as a github app to get the correct label or at least adding [bot] to the username.

The changes were pushed to a fork by a bot. The PRs themselves were created manually - I had planned to curate and then request review when they were ready for review. Next time for manual curation I will just PR against my own fork to review changes before PR to nf-core

Still testing out the bot on the CLI-side. In any case, I have changed the name of this account to include [bot] but its not an app at this point (nor technically a bot)

Some context for you both @SPPearce @mashehu

@nf-core nf-core deleted a comment from maxcumminsandfred-lab Mar 4, 2026
@maxcumminsandfred-lab
Copy link
Contributor Author

maxcumminsandfred-lab commented Mar 4, 2026

Can't update snapshots locally due to ARM architecture seemingly not liking deacon container. Tried tagging @nf-core-bot update snapshot - not sure if I don't have permission to tag or if I got the command wrong, got no response.

Full command not detailed here for regular snapshot updates, only other snapshot types - https://nf-co.re/docs/contributing/github/nf-core-bot

@mashehu
Copy link
Contributor

mashehu commented Mar 4, 2026

because this bot action doesn't exist (yet) for this repo. you can use github codespaces to update snapshots with a x86 machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants