Skip to content

fix(setup): prevent unnecessary mime migrations on new installs #58235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(setup): prevent unnecessary mime migrations on new installs #58235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02108c4
fix(setup): prevent unnecessary mime migrations on new installs
joshtrichards Feb 10, 2026
70266d1
fix(Repair): make sure <v29 mime type repairs aren't skipped
joshtrichards Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions lib/private/Repair/RepairMimeTypes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,13 +389,11 @@ public function migrationsAvailable(): bool {
* Get the current mimetype version
*/
private function getMimeTypeVersion(): string {
$serverVersion = $this->config->getSystemValueString('version', '0.0.0');
// 29.0.0.10 is the last version with a mimetype migration before it was moved to a separate version number
if (version_compare($serverVersion, '29.0.0.10', '>')) {
return $this->appConfig->getValueString('files', 'mimetype_version', '29.0.0.10');
}

return $serverVersion;
// 29.0.0.10 is the last version with a mimetype migration before tracking was moved to mimetype_version.
// However since it's possible that someone may have upgraded without running expensive repair steps prior
// to 29.0.0.10, we assume none have been ran (once). This is acceptable since (a) only happens when expensive
// repair steps are explicitly requested; (b) only happens once *ever* in a given environment.
return $this->appConfig->getValueString('files', 'mimetype_version', '0.0.0');
}

/**
Expand Down
4 changes: 4 additions & 0 deletions lib/private/Setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,10 @@ public function install(array $options, ?IOutput $output = null): array {
}
}

// Seed the mimetype_version for future mimetype repair jobs with the install-time version
$serverVersion = $config->getSystemValueString('version', '0.0.0');
$appConfig->setValueString('files', 'mimetype_version', $serverVersion);

// Dispatch installation completed event
$adminUsername = !$disableAdminUser ? ($options['adminlogin'] ?? null) : null;
$adminEmail = !empty($options['adminemail']) ? $options['adminemail'] : null;
Expand Down
Loading