Skip to content

fix(setup): prevent unnecessary mime migrations on new installs #58235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(setup): prevent unnecessary mime migrations on new installs #58235

joshtrichards wants to merge 2 commits into from

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Feb 10, 2026

Summary

  • Avoids running the repairs for prior versions on new installs
    • also avoids the misleading/confusing setup check warning on new installations about "One or more mimetype migrations are available [...] Use the command occ maintenance:repair --include-expensive to perform the migrations".
  • Also makes sure that <v29 mime type repairs aren't skipped inadvertently regardless of upgrade path.
    • Still only runs if necessary except in a single scenario: an environment that had pre-v29 mime repair steps that were never ran and is now running >v29. And even then only when explicitly triggered and only once ever.

TODO

  • ...

Checklist

@joshtrichards
fix(setup): prevent unnecessary mime migrations on new installs
02108c4 
Avoids running the repairs for prior versions (that are otherwise a no-op) and also avoids the misleading/confusing setup check warning on new installations about "One oe more mimetype migrations are available [...]".

Signed-off-by: Josh <[email protected]>
@joshtrichards
fix(Repair): make sure <v29 mime type repairs aren't skipped
70266d1 
- fix: Makes it impossible to accidentally skip pre-v29 mime repair steps even if one has skipped them up past v29. With the old behavior, when triggering mime type repair steps in an environment that's been upgraded from pre-v29 w/o running some steps, it was possible to never be able to run the earlier skipped steps. This change makes things consistent and clean.
- cleanup: Drops no longer needed 29.0.0.10 version check

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards requested a review from a team as a code owner February 10, 2026 19:07
@joshtrichards joshtrichards requested review from ArtificialOwl, come-nc, icewind1991 and leftybournes and removed request for a team February 10, 2026 19:07
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Feb 10, 2026
@joshtrichards
Copy link
Member Author

joshtrichards commented Feb 10, 2026

/backport to stable33

@joshtrichards
Copy link
Member Author

joshtrichards commented Feb 10, 2026

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: install and update

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

mimetype migrations warning after fresh Docker install

1 participant

@joshtrichards