Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€ 3๋‹จ๊ณ„ - ์ž๋™์ฐจ ๊ฒฝ์ฃผ #5920

Open
wants to merge 9 commits into
base: jonghoonok
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,25 @@
* ๋ชจ๋“  ํ”ผ๋“œ๋ฐฑ์„ ์™„๋ฃŒํ•˜๋ฉด ๋‹ค์Œ ๋‹จ๊ณ„๋ฅผ ๋„์ „ํ•˜๊ณ  ์•ž์˜ ๊ณผ์ •์„ ๋ฐ˜๋ณตํ•œ๋‹ค.

## ์˜จ๋ผ์ธ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๊ณผ์ •
* [ํ…์ŠคํŠธ์™€ ์ด๋ฏธ์ง€๋กœ ์‚ดํŽด๋ณด๋Š” ์˜จ๋ผ์ธ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๊ณผ์ •](https://github.com/next-step/nextstep-docs/tree/master/codereview)
* [ํ…์ŠคํŠธ์™€ ์ด๋ฏธ์ง€๋กœ ์‚ดํŽด๋ณด๋Š” ์˜จ๋ผ์ธ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๊ณผ์ •](https://github.com/next-step/nextstep-docs/tree/master/codereview)

## ๊ตฌํ˜„ํ•  ๊ธฐ๋Šฅ ๋ชฉ๋ก
### ๐Ÿš€ 3๋‹จ๊ณ„ - ์ž๋™์ฐจ ๊ฒฝ์ฃผ
> **์š”๊ตฌ์‚ฌํ•ญ**
> - ์ดˆ๊ฐ„๋‹จ ์ž๋™์ฐจ ๊ฒฝ์ฃผ ๊ฒŒ์ž„์„ ๊ตฌํ˜„ํ•œ๋‹ค.
> - ์ฃผ์–ด์ง„ ํšŸ์ˆ˜ ๋™์•ˆ n๋Œ€์˜ ์ž๋™์ฐจ๋Š” ์ „์ง„ ๋˜๋Š” ๋ฉˆ์ถœ ์ˆ˜ ์žˆ๋‹ค.
> - ์‚ฌ์šฉ์ž๋Š” ๋ช‡ ๋Œ€์˜ ์ž๋™์ฐจ๋กœ ๋ช‡ ๋ฒˆ์˜ ์ด๋™์„ ํ•  ๊ฒƒ์ธ์ง€๋ฅผ ์ž…๋ ฅํ•  ์ˆ˜ ์žˆ์–ด์•ผ ํ•œ๋‹ค.
> - ์ „์ง„ํ•˜๋Š” ์กฐ๊ฑด์€ 0์—์„œ 9 ์‚ฌ์ด์—์„œ random ๊ฐ’์„ ๊ตฌํ•œ ํ›„ random ๊ฐ’์ด 4์ด์ƒ์ผ ๊ฒฝ์šฐ์ด๋‹ค.
> - ์ž๋™์ฐจ์˜ ์ƒํƒœ๋ฅผ ํ™”๋ฉด์— ์ถœ๋ ฅํ•œ๋‹ค. ์–ด๋Š ์‹œ์ ์— ์ถœ๋ ฅํ•  ๊ฒƒ์ธ์ง€์— ๋Œ€ํ•œ ์ œ์•ฝ์€ ์—†๋‹ค.

๊ตฌํ˜„ ๋ชฉ๋ก
- [x] ์‚ฌ์šฉ์ž๋กœ๋ถ€ํ„ฐ ๊ฐ’์„ ์ž…๋ ฅ๋ฐ›๋Š”๋‹ค.
- [x] ์ž…๋ ฅ๋ฐ›์€ ๊ฐ’์„ ์ด์šฉํ•ด ์ž๋™์ฐจ ๊ฐ์ฒด๋ฅผ ์ƒ์„ฑํ•œ๋‹ค.
- [x] ์ž…๋ ฅ๋ฐ›์€ ๊ฐ’์„ ์ด์šฉํ•ด ์‹คํ–‰๋˜๋Š” ๊ฒŒ์ž„์˜ ๋กœ์ง์„ ๊ตฌํ˜„ํ•œ๋‹ค.
- [x] ๊ฒŒ์ž„ ๋‚ด์—์„œ ์ž๋™์ฐจ๊ฐ€ ์ „์ง„ ๋˜๋Š” ๋ฉˆ์ถ”๊ฒŒ ํ•œ๋‹ค.
- [x] ์ž๋™์ฐจ์˜ ์ƒํƒœ๋ฅผ ํ™”๋ฉด์— ์ถœ๋ ฅํ•œ๋‹ค.

ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜
- [x] CarTest: ๊ฒฝ๊ณ„๊ฐ’์„ ํ…Œ์ŠคํŠธํ•  ์ˆ˜ ์žˆ๋„๋ก ๋ณ€๊ฒฝํ•˜๊ธฐ
- [x] ์ปจํŠธ๋กค๋Ÿฌ๊ฐ€ ์ƒํƒœ๋ฅผ ๊ฐ–๋Š”๊ฒŒ ์ ์ ˆํ•œ์ง€(Cars), ๋‹ค๋ฅธ ์ปจํŠธ๋กค๋Ÿฌ๋ฅผ ๊ฐ–๋Š”๊ฒŒ ๋งž๋Š”์ง€(CarController) ๊ณ ๋ฏผ
- [x] CarController์—์„œ random์„ ์ œ๊ฑฐํ•˜๊ณ  moveAll() ํ…Œ์ŠคํŠธ ๊ฐ€๋Šฅํ•˜๋„๋ก ๋ณ€๊ฒฝํ•˜๊ธฐ
10 changes: 10 additions & 0 deletions src/main/java/car_racing/Main.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package car_racing;

import car_racing.application.GameController;

public class Main {
public static void main(String[] args) {
GameController gameController = new GameController();
gameController.run();
}
}
18 changes: 18 additions & 0 deletions src/main/java/car_racing/application/GameController.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package car_racing.application;

import car_racing.domain.service.RaceService;
import car_racing.domain.strategy.CarMovingStrategy;
import car_racing.domain.strategy.RandomMovingStrategy;
import car_racing.view.model.UserInput;
import car_racing.view.service.UserInputService;

public class GameController {
private final UserInputService userInputProcessor = new UserInputService();
private final RaceService raceService = new RaceService();
private final CarMovingStrategy carMovingStrategy = new RandomMovingStrategy();

public void run() {
UserInput userInput = userInputProcessor.getUserInput();
raceService.race(userInput, carMovingStrategy);
}
}
14 changes: 14 additions & 0 deletions src/main/java/car_racing/domain/model/Car.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package car_racing.domain.model;

public class Car {
private int distance;

public void move(int distance) {
if (distance < 0) throw new IllegalArgumentException("์ž๋™์ฐจ๋Š” ์Œ์ˆ˜๋งŒํผ ์›€์ง์ผ ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค.");
this.distance += distance;
}

public int getDistance() {
return distance;
}
}
32 changes: 32 additions & 0 deletions src/main/java/car_racing/domain/model/Cars.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package car_racing.domain.model;

import car_racing.domain.strategy.CarMovingStrategy;

import java.util.ArrayList;
import java.util.List;
import java.util.function.Consumer;

public class Cars {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ๊ธ‰์ปฌ๋ ‰์…˜ ๐Ÿ‘

private static final int DEFAULT_MOVE_DISTANCE = 1;

private final List<Car> cars;
private final CarMovingStrategy movingStrategy;

public Cars(int numOfCars, CarMovingStrategy movingStrategy) {
this.cars = new ArrayList<>();
this.movingStrategy = movingStrategy;
for (int i = 0; i < numOfCars; i++) {
this.cars.add(new Car());
}
}

public void moveAll() {
cars.forEach(car -> {
if (movingStrategy.movable()) car.move(DEFAULT_MOVE_DISTANCE);
});
}

public void forEach(Consumer<Car> action) {
cars.forEach(action);
}
}
30 changes: 30 additions & 0 deletions src/main/java/car_racing/domain/service/RaceService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package car_racing.domain.service;

import car_racing.domain.strategy.CarMovingStrategy;
import car_racing.domain.model.Cars;
import car_racing.view.service.PrintService;
import car_racing.view.model.UserInput;

public class RaceService {
public void race(UserInput userInput, CarMovingStrategy carMovingStrategy) {
Cars cars = new Cars(userInput.getNumOfCar(), carMovingStrategy);

showRaceStart();
for (int i = 0; i < userInput.getNumOfGame(); i++) {
playRound(cars);
}
}

private void playRound(Cars cars) {
cars.moveAll();
showRaceResult(cars);
}

private void showRaceStart() {
PrintService.showRaceStart();
}

private void showRaceResult(Cars cars) {
PrintService.showRaceResult(cars);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package car_racing.domain.strategy;

public class AlwaysMovingStrategy implements CarMovingStrategy {
@Override
public boolean movable() {
return true;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package car_racing.domain.strategy;

public interface CarMovingStrategy {
boolean movable();
}
14 changes: 14 additions & 0 deletions src/main/java/car_racing/domain/strategy/RandomMovingStrategy.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package car_racing.domain.strategy;

import java.util.Random;

public class RandomMovingStrategy implements CarMovingStrategy{
private static final Random random = new Random();
private static final int MOVE_THRESHOLD = 4;


@Override
public boolean movable() {
return random.nextInt() > MOVE_THRESHOLD;
}
}
19 changes: 19 additions & 0 deletions src/main/java/car_racing/view/model/UserInput.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package car_racing.view.model;

public class UserInput {
private final int numOfCar;
private final int numOfGame;

public UserInput(int numOfCar, int numOfGame) {
this.numOfCar = numOfCar;
this.numOfGame = numOfGame;
}

public int getNumOfCar() {
return numOfCar;
}

public int getNumOfGame() {
return numOfGame;
}
}
19 changes: 19 additions & 0 deletions src/main/java/car_racing/view/service/PrintService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package car_racing.view.service;

import car_racing.domain.model.Car;
import car_racing.domain.model.Cars;

public class PrintService {
public static void showRaceStart() {
System.out.println("\n์‹คํ–‰ ๊ฒฐ๊ณผ");
}

public static void showRaceResult(Cars cars) {
cars.forEach(PrintService::showEachRaceResult);
System.out.println();
}

private static void showEachRaceResult(Car car) {
System.out.println("-".repeat(car.getDistance()));
}
}
25 changes: 25 additions & 0 deletions src/main/java/car_racing/view/service/UserInputService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package car_racing.view.service;

import car_racing.view.model.UserInput;

import java.util.Scanner;

public class UserInputService {
private static final Scanner scanner = new Scanner(System.in);

public UserInput getUserInput() {
int numOfCar = getNumOfCar();
int numOfGame = getNumOfGame();
return new UserInput(numOfCar, numOfGame);
}

private int getNumOfCar() {
System.out.println("์ž๋™์ฐจ ๋Œ€์ˆ˜๋Š” ๋ช‡ ๋Œ€ ์ธ๊ฐ€์š”?");
return scanner.nextInt();
}

private int getNumOfGame() {
System.out.println("์‹œ๋„ํ•  ํšŒ์ˆ˜๋Š” ๋ช‡ ํšŒ ์ธ๊ฐ€์š”?");
return scanner.nextInt();
}
}
38 changes: 38 additions & 0 deletions src/test/java/car_racing/CarTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package car_racing;

import car_racing.domain.model.Car;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;
import org.junit.jupiter.params.provider.ValueSource;

import static org.assertj.core.api.Assertions.assertThatCode;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;

class CarTest {
@ParameterizedTest(name = "์ž๋™์ฐจ๋ฅผ ์›€์ง์ด๋ฉด ์ž๋™์ฐจ๊ฐ€ ์›€์ง์ธ ๋งŒํผ ์œ„์น˜๊ฐ€ ๋ณ€ํ•œ๋‹ค. ์›€์ง์ธ ๊ฐ’: {0}")
@ValueSource(ints = {1, 2, 3})
void shouldMoveCarByGivenDistance(int inputDistance) {
Car car = new Car();
car.move(inputDistance);
assertThat(car.getDistance()).isEqualTo(inputDistance);
}

@ParameterizedTest(name = "์ž๋™์ฐจ๋ฅผ ์Œ์ˆ˜๋งŒํผ ์›€์ง์ด๋ฉด ์˜ˆ์™ธ๊ฐ€ ๋ฐœ์ƒํ•œ๋‹ค. ์›€์ง์ธ ๊ฐ’: {0}")
@CsvSource({
"-1, true",
"0, false",
"1, false"
})
void sholdThrowRuntimeExceptionWhenNegativeDistanceIsGiven(int inputDistance, boolean shouldThrow) {
Car car = new Car();

if (shouldThrow) {
assertThatThrownBy(() -> car.move(inputDistance))
.isInstanceOf(RuntimeException.class);
} else {
assertThatCode(() -> car.move(inputDistance))
.doesNotThrowAnyException();
}
}
}
18 changes: 18 additions & 0 deletions src/test/java/car_racing/domain/model/CarsTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package car_racing.domain.model;

import car_racing.domain.strategy.AlwaysMovingStrategy;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

class CarsTest {
@Test
@DisplayName("moveAll ํ˜ธ์ถœ์‹œ ๋ชจ๋“  ์ฐจ๋Ÿ‰์ด 1๋งŒํผ ์›€์ง์ด๋Š”์ง€")
void shouldMoveAll() {
Cars cars = new Cars(3, new AlwaysMovingStrategy());
cars.moveAll();

cars.forEach(car -> assertEquals(1, car.getDistance()));
}
}