π 3λ¨κ³ - μλμ°¨ κ²½μ£Ό #5920
Conversation
κΈ°λ₯ λͺ©λ‘ 체ν¬λ¦¬μ€νΈ μμ±
- κ°μ μ λ ₯λ°λ UserInputProcessor μμ± - κ°μ λ΄λ UserInput μμ± - νλ‘κ·Έλ¨μ μ€ννλ Main μμ± - κ²μμ μ€ννλ GameController μμ±
- μμΉλΌλ μνμ μνλ₯Ό λ³κ²½νλ λ©μλλ₯Ό κ°λ Car μμ± - Carμ λν ν μ€νΈ μμ±
- μ λ ₯λ°μ κ°λ§νΌμ Carλ₯Ό κ°κ³ μ΄λ€μ μμ§μ΄λ CarController μμ± - CarController λ΄λΆμμ randomμ μ΄μ©νμ¬ Carλ₯Ό μ΄λμν€λλ‘ ν¨
- Carμ 리μ€νΈλ₯Ό λ°μμ μ 체 μλμ°¨μ μνλ₯Ό μΆλ ₯νλ CarPrinter μμ± - CarController λ΄λΆμμ CarPrinterλ₯Ό νΈμΆνμ¬ μνλ₯Ό μΆλ ₯νκ² ν¨
- Carμ 리μ€νΈλ₯Ό κ°λ 1κΈ μ»¬λ μ Cars μμ± - domain, view ν¨ν€μ§ λΆλ¦¬
| private final Cars cars; | ||
| private final UserInput userInput; | ||
|
|
||
| public CarController(UserInput userInput) { | ||
| this.userInput = userInput; | ||
| this.cars = new Cars(userInput.getNumOfCar()); | ||
| } |
There was a problem hiding this comment.
MVCν¨ν΄μ κΈ°λ°νμ κ±° κ°μ΅λλ€.
Controllerλ κ³Όμ° μνλ₯Ό κ°μ§κ³ μλκ² λ§μκΉμ?
μ¦, μΈμ€ν΄μ€λ³μλ‘ Carsλ₯Ό κ°μ§κ³ μλκ² λ§μμ§... κ³ λ―Όμ ν΄λ³΄μλ©΄ μ΄λ¨κΉμ?
| public class GameController { | ||
| private final UserInputProcessor userInputProcessor = new UserInputProcessor(); | ||
|
|
||
| public void run() { | ||
| UserInput userInput = userInputProcessor.getUserInput(); | ||
| CarController carController = new CarController(userInput); | ||
| carController.race(); | ||
| } |
There was a problem hiding this comment.
Controllerκ° Controllerλ₯Ό κ°μ§κ³ μλ ννκ° MVCμμ κΈ°λ°λλκ±ΈκΉμ?
| private boolean isMovable() { | ||
| return random.nextInt() > MOVE_THRESHOLD; | ||
| } |
There was a problem hiding this comment.
μ¬κΈ°μ λλ€μ μ μ΄νλ€λ©΄, Carsμ λν moveAllμ λν ν μ€νΈκ° νλ€κ±° κ°μ΅λλ€.
νλ² μλ κΈμ μ°Έκ³ ν΄λ³΄μλ©΄ μ΄λ¨κΉμ?
https://tecoble.techcourse.co.kr/post/2020-05-17-appropriate_method_for_test_by_interface/
| @ParameterizedTest(name = "μλμ°¨λ₯Ό μμ§μ΄λ©΄ μλμ°¨κ° μμ§μΈ λ§νΌ μμΉκ° λ³νλ€. μμ§μΈ κ°: {0}") | ||
| @ValueSource(ints = {1, 2, 3}) | ||
| void shouldMoveCarByGivenDistance(int inputDistance) { | ||
| Car car = new Car(); | ||
| car.move(inputDistance); | ||
| assertThat(car.getDistance()).isEqualTo(inputDistance); | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "μλμ°¨λ₯Ό μμλ§νΌ μμ§μ΄λ©΄ μλ¬κ° λ°μνλ€. μμ§μΈ κ°: {0}") | ||
| @ValueSource(ints = {-1, -2, -3}) | ||
| void sholdThrowRuntimeExceptionWhenNegativeDistanceIsGiven(int inputDistance) { | ||
| Car car = new Car(); | ||
| assertThatThrownBy(() -> car.move(inputDistance)) | ||
| .isInstanceOf(RuntimeException.class); | ||
| } |
There was a problem hiding this comment.
κ²½κ³κ°μ ν
μ€νΈν΄λΌ. λΌλ λ§μ΄ μμ΅λλ€.
μμμ μμλ₯Ό κ²μ¦ν΄μΌ νλλ°μ.
κ·Έλ λ€λ©΄ μμμ μμμ κ²½κ³μ μ μ΄λμΌκΉμ?
-1κ³Ό 1μ΄λΌκ³ μκ°ν©λλ€.
κ·Έ λκ°μ§ ν
μ€νΈλ‘ μΆ©λΆν ν μ μμ§ μμκΉμ?
1μ κ²μ¦νλ€μ 2,3μ κ²μ¦νλκ²μ λν΄ ν° μλ―Έκ° μμκΉμ?
νλ² κ³ λ―Όν΄λ³΄μλ©΄ μ’μκ±° κ°μ΅λλ€!
| import java.util.Random; | ||
| import java.util.function.Consumer; | ||
|
|
||
| public class Cars { |
μλ νμΈμ, μ€λλ 리뷰 μ λΆνλ립λλ€.
randomμ λν ν μ€νΈ μμ± λ±μ΄ μ’ μ 맀ν΄μ ν μ€νΈ μ½λκ° λΆμ‘±ν κ°μ΄ μλλ°μ,
οΏ½ν μ€νΈλ₯Ό μ΄λ€ μμΌλ‘ μμ±νλ©΄ μ’μμ§ μ€μ¬μΌλ‘ νΌλλ°± ν΄μ£Όμλ©΄ κ°μ¬νκ² μ΅λλ€!