-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π 3λ¨κ³ - GitHub(UI μν) #52
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4ec8d80
docs : κΈ°λ₯ μꡬμ¬ν μ 리
ethanchaee 6239f0f
feat : λ‘λ© UI, λΉνλ©΄ UI λ
ΈμΆ
ethanchaee ce6aa6c
refactor : state μμ
ethanchaee 9819485
feat : μλ¬ λ°μ μ, μ€λ΅λ° λ
ΈμΆ
ethanchaee 20f7319
chore : νμμλ μΊμ€ν
μμ
ethanchaee 4361d28
docs : μμ
λ΄μ μ
λ°μ΄νΈ
ethanchaee a2704b4
chore : Box μ κ±°
ethanchaee 751b806
chore : Typography μμ
ethanchaee a72c9b7
fix : μ€λ΅λ° λ
ΈμΆ λ‘μ§ μμ
ethanchaee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
app/src/main/java/nextstep/github/ui/component/GithubRepositoryEmpty.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package nextstep.github.ui.component | ||
|
||
import androidx.compose.foundation.background | ||
import androidx.compose.foundation.layout.Box | ||
import androidx.compose.foundation.layout.fillMaxSize | ||
import androidx.compose.material3.MaterialTheme | ||
import androidx.compose.material3.Text | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Alignment | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.res.stringResource | ||
import androidx.compose.ui.tooling.preview.Preview | ||
import nextstep.github.R | ||
import nextstep.github.ui.theme.GithubTheme | ||
import nextstep.github.ui.theme.Typography | ||
|
||
@Composable | ||
internal fun GithubRepositoryEmpty(modifier: Modifier = Modifier) { | ||
Box( | ||
modifier = modifier | ||
.fillMaxSize() | ||
.background(color = MaterialTheme.colorScheme.surface), | ||
contentAlignment = Alignment.Center, | ||
) { | ||
Text( | ||
text = stringResource(R.string.github_repositories_empty), | ||
style = Typography.headlineSmall, | ||
) | ||
} | ||
} | ||
|
||
|
||
@Preview(showBackground = true) | ||
@Composable | ||
private fun GithubRepositoryEmptyPreview() { | ||
GithubTheme { | ||
GithubRepositoryEmpty() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μλ¬ νλ©΄μΌ κ²½μ° Previewλ μ΄λ»κ² νμΈν΄λ³΄λ©΄ λλκ±ΈκΉμ? π€
λ§μ½ λ°©λ²μ μμ λ€λ©΄, μ΄λ»κ² νμΈν΄μΌνλμ§ μ½λλ§ λ³΄κ³ μΈμ§ν μ μμΌλ©΄ μ’μ κ² κ°μλ° μμλμ μ΄λ»κ² μκ°νμλμ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ§λ¬Έμ μ μ΄ν΄νμ§ λͺ»νμ΅λλ€.
ν΄λΉ preview λΉλ μ, μλ¬ νλ©΄μ΄ λ‘λ λκ³ , μ¬μλ λ²νΌ ν΄λ¦ μ, λΉνλ©΄μ΄ λ ΈμΆλκ² ν΄μ μνμ λ°λ₯Έ λ³νλ μ λ°μ΄νΈ λλ κ² νμΈνμ΅λλ€.
μ½λμμ
μ΅μ΄ repositoryState λ₯Ό Error λ‘ ν λΉνκ³ ,
retryAction ν΄λ¦ μ, respositoryState λ₯Ό empty λ‘ μ λ°μ΄νΈ ν΄μ νμΈν μ μκ² κ°λ°νμ΅λλ€.
μ΄λ»κ² νμΈν΄μΌ νλμ§ μ½λλ§ λ³΄κ³ μΈμ§νκ² νλ €λ©΄, μ£ΌμμΌλ‘ ν μ€νΈ λ°©λ²μ μ¨λμΌ ν κΉμ?
preview λΉλ ν΄λ³΄κ³ λ κ°λ¨ν interaction mode μ΄μ©νλ©΄ λ°λ‘ νμΈν μ μμκ±°λΌ μκ°νλλ° μ΄λ€ λΆλΆμ΄ μ΄λ €μ°μ ¨μκΉμ?
Screen_recording_20250312_231800.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethanchaee
μΌλ°μ μΌλ‘ Previewλ μλλ‘μ΄λ μ€νλμ€ μμμ UIκ° μ΄λ»κ² κ·Έλ €μ§λμ§ νμΈν ν λ°μ.
μμλκ»μλ ν΄λΉ Previewλ λΉλλ₯Ό ν΄μ μ§μ νμΈν΄λ΄μΌνλ€λ κ²μ μμμ§λ§, λλ£κ° λ΄€μ λ Previewλ₯Ό λΉλλ₯Ό ν΄μ μ§μ νμΈν΄λ΄μΌνλ€λ κ²μ μ΄λ»κ² μ μ μμκΉμ? π€
νΉμ μμλκ»μ Previewλ₯Ό λ΄€μ λ "μ μ΄κ±΄ λΉλλ₯Ό ν΄μ νμΈν΄λ΄μΌκ² λ€" νλ κΈ°μ€μ΄ μμκΉμ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ³΄ν΅ μ½λ리뷰 ν λ, νλ²μ© μ€ν ν΄λ³΄λ νΈμ λλ€.
νΉν ν΄λ¦ μΈν°λμ , μ λλ©μ΄μ , λ€μ΄μΌλ‘κ·Έ, μ€λ΅λ°κ° μμ λλ μΈν°λμ μ 보기μν΄, λΉλλ₯Ό ν΄λ³΄κ±°λ, interaction mode λ₯Ό νμ©νλλ°μ.
μ λ ν΄λΉ ν리뷰λ₯Ό μμ±νμ λ, μλ¬κ° λ°μνκ³ , λ°μ μ΄νμ ν΄λ¦ μ, μ±κ³΅μΌλ‘ μνκ° λ³κ²½λλ κ²μ 보μ¬μ£ΌκΈ° μν¨μ΄μμ΅λλ€.
μ΄λ° μκ°μ κ°μ§κ³ μλ€ λ³΄λ λΉμ°ν λΉλ ν΄λ΄μΌ νλ€κ³ μκ°νλλ°μ.
νμλμ΄ μ§λ¬Έμ£Όμ λ΄μ© λ³΄κ³ μκ°ν΄λ³΄λ, preview λ‘ λ¨μ UI λ ΈμΆμ κΈ°λνμ§, μμ κ°μ κ³Όμ μ κΈ°λν κ±°λΌ μκ°λμ§ μλ€μ.
μ΄λ° μΌμ΄μ€λΌλ©΄, ν리뷰 보λ€λ ViewModel ν μ€νΈλ‘ μ§ννλκ² λ μ μ νλ€κ³ μκ°μ΄ λ€μμ΅λλ€.
λλ, RespoitoryState μνμ λ°λ₯Έ νλ©΄μ 보μ¬μ£Όλ κ²μ΄λ€ λΌλ κ±Έ ννν μ μλ λ€λ₯Έ λ€μ΄λ°μ΄ μ’κ² λ€ λΌλ μκ°λ λ€μμ΅λλ€.
ν리뷰λ₯Ό μ’ λ νλ¦¬λ·°λ‘ νμ©νκ±°λ,
볡μ‘ν ν리뷰μ κ²½μ° λ λͺ μμ μΈ λ€μ΄λ° λλ μμΈ μ€λͺ μ΄ νμνλ€κ³ λκΌμ΅λλ€.
λ€μ ν λ² μκ° ν΄λ³Ό μ μκ² μ§λ¬Έ μ£Όμ μ κ°μ¬ν©λλ€.