Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ 3단계 - GitHub(UI μƒνƒœ) #52

Merged
merged 9 commits into from
Mar 13, 2025

Conversation

ethanchaee
Copy link

step3 UI state

κ΅¬ν˜„μ‚¬ν•­

  • λ‘œλ”©ν™”λ©΄
  • 빈λͺ©λ‘ ν™”λ©΄
  • 였λ₯˜ λ°œμƒ μ‹œ, λ‹€μ‹œ μ‹œλ„κ°€ κ°€λŠ₯ν•œ μŠ€λ‚΅λ°” λ…ΈμΆœ

μ•ˆλ…•ν•˜μ„Έμš” ν˜„μ„λ‹˜,

κΆκΈˆν•œ 점이 ν•˜λ‚˜ μžˆμŠ΅λ‹ˆλ‹€.
ν”„λ‘œκ·Έλž˜λ° μš”κ΅¬ 사항 쀑에, κΈ°λŠ₯ μš”κ΅¬ 사항에 λŒ€ν•œ UI ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•œλ‹€ λΌλŠ” λ‚΄μš©μ΄ μžˆμ—ˆλŠ”λ°μš”.
UI ν…ŒμŠ€νŠΈ μž‘μ„±ν•˜λ‹€ λ³΄λ‹ˆ, μΌ€μ΄μŠ€ λ³„λ‘œ κ΅¬ν˜„ν•œ Preview 와 ν…ŒμŠ€νŠΈ μΌ€μ΄μŠ€κ°€ λ™μΌν•΄μ„œ UI ν…ŒμŠ€νŠΈλŠ” μž‘μ„±ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.
UI ν…ŒμŠ€νŠΈλŠ” λ‘œμ§μ„ κ²€μ¦ν•˜μ§€ μ•Šκ³ , λ…ΈμΆœμ— 쀑점을 λ‘”λ‹€λŠ” μˆ˜μ—… λ‚΄μš©μ„ 미루어 봀을 λ•Œλ„, ν•„μš” μ—†μ–΄ λ³΄μž…λ‹ˆλ‹€.
ν˜„μ„λ‹˜μ˜ 생각은 어떠신지 κΆκΈˆν•©λ‹ˆλ‹€.

리뷰 잘 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€ πŸ™‡β€β™€οΈ

Copy link

@BeokBeok BeokBeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 단계 ν”Όλ“œλ°±κ³Ό Github(UI μƒνƒœ) λ―Έμ…˜ν•˜μ‹œλŠλΌ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. πŸ‘
κ³ λ―Όν•΄λ³Όλ§Œν•œ μ˜κ²¬λ“€μ„ μ½”λ§¨νŠΈλ‘œ μž‘μ„±ν•˜μ˜€μœΌλ‹ˆ, μΆ©λΆ„νžˆ κ³ λ―Όν•΄λ³΄μ‹œκ³  λ„μ „ν•΄λ³΄μ„Έμš”. πŸ’ͺ

)
}
}

@Preview
@Composable
private fun GithubRepositoryScreePreview() {
private fun GithubRepositoryScreeErrorPreview() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—λŸ¬ 화면일 경우 PreviewλŠ” μ–΄λ–»κ²Œ 확인해보면 λ˜λŠ”κ±ΈκΉŒμš”? πŸ€”
λ§Œμ•½ 방법을 μ•„μ‹ λ‹€λ©΄, μ–΄λ–»κ²Œ ν™•μΈν•΄μ•Όν•˜λŠ”μ§€ μ½”λ“œλ§Œ 보고 인지할 수 있으면 쒋을 것 같은데 μƒμ•„λ‹˜μ€ μ–΄λ–»κ²Œ μƒκ°ν•˜μ‹œλ‚˜μš”?

Copy link
Author

@ethanchaee ethanchaee Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ§ˆλ¬Έμ„ 잘 μ΄ν•΄ν•˜μ§€ λͺ»ν–ˆμŠ΅λ‹ˆλ‹€.

ν•΄λ‹Ή preview λΉŒλ“œ μ‹œ, μ—λŸ¬ 화면이 λ‘œλ“œ 되고, μž¬μ‹œλ„ λ²„νŠΌ 클릭 μ‹œ, λΉˆν™”λ©΄μ΄ λ…ΈμΆœλ˜κ²Œ ν•΄μ„œ μƒνƒœμ— λ”°λ₯Έ 변화도 μ—…λ°μ΄νŠΈ λ˜λŠ” 것 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

μ½”λ“œμ—μ„œ
졜초 repositoryState λ₯Ό Error 둜 ν• λ‹Ήν•˜κ³ ,
retryAction 클릭 μ‹œ, respositoryState λ₯Ό empty 둜 μ—…λ°μ΄νŠΈ ν•΄μ„œ 확인할 수 있게 κ°œλ°œν–ˆμŠ΅λ‹ˆλ‹€.

μ–΄λ–»κ²Œ 확인해야 ν•˜λŠ”μ§€ μ½”λ“œλ§Œ 보고 μΈμ§€ν•˜κ²Œ ν•˜λ €λ©΄, μ£Όμ„μœΌλ‘œ ν…ŒμŠ€νŠΈ 방법을 써놔야 ν• κΉŒμš”?
preview λΉŒλ“œ ν•΄λ³΄κ³ λ‚˜ κ°„λ‹¨νžˆ interaction mode μ΄μš©ν•˜λ©΄ λ°”λ‘œ 확인할 수 μžˆμ„κ±°λΌ μƒκ°ν–ˆλŠ”λ° μ–΄λ–€ 뢀뢄이 μ–΄λ €μš°μ…¨μ„κΉŒμš”?

Screen_recording_20250312_231800.webm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanchaee
일반적으둜 PreviewλŠ” μ•ˆλ“œλ‘œμ΄λ“œ μŠ€νŠœλ””μ˜€ μƒμ—μ„œ UIκ°€ μ–΄λ–»κ²Œ κ·Έλ €μ§€λŠ”μ§€ ν™•μΈν• ν…λ°μš”.
μƒμ•„λ‹˜κ»˜μ„œλŠ” ν•΄λ‹Ή PreviewλŠ” λΉŒλ“œλ₯Ό ν•΄μ„œ 직접 ν™•μΈν•΄λ΄μ•Όν•œλ‹€λŠ” 것을 μ•„μ‹œμ§€λ§Œ, λ™λ£Œκ°€ 봀을 λ•Œ Previewλ₯Ό λΉŒλ“œλ₯Ό ν•΄μ„œ 직접 ν™•μΈν•΄λ΄μ•Όν•œλ‹€λŠ” 것을 μ–΄λ–»κ²Œ μ•Œ 수 μžˆμ„κΉŒμš”? πŸ€”
ν˜Ήμ‹œ μƒμ•„λ‹˜κ»˜μ„œ Previewλ₯Ό 봀을 λ•Œ "μ•„ 이건 λΉŒλ“œλ₯Ό ν•΄μ„œ 확인해봐야겠닀" ν•˜λŠ” 기쀀이 μžˆμ„κΉŒμš”?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보톡 μ½”λ“œλ¦¬λ·° ν•  λ•Œ, ν•œλ²ˆμ”© μ‹€ν–‰ ν•΄λ³΄λŠ” νŽΈμž…λ‹ˆλ‹€.
특히 클릭 μΈν„°λž™μ…˜, μ• λ‹ˆλ©”μ΄μ…˜, λ‹€μ΄μ–Όλ‘œκ·Έ, μŠ€λ‚΅λ°”κ°€ μžˆμ„ λ•ŒλŠ” μΈν„°λž™μ…˜μ„ λ³΄κΈ°μœ„ν•΄, λΉŒλ“œλ₯Ό ν•΄λ³΄κ±°λ‚˜, interaction mode λ₯Ό ν™œμš©ν•˜λŠ”λ°μš”.

μ €λŠ” ν•΄λ‹Ή 프리뷰λ₯Ό μƒμ„±ν–ˆμ„ λ•Œ, μ—λŸ¬κ°€ λ°œμƒν–ˆκ³ , λ°œμƒ 이후에 클릭 μ‹œ, μ„±κ³΅μœΌλ‘œ μƒνƒœκ°€ λ³€κ²½λ˜λŠ” 것을 보여주기 μœ„ν•¨μ΄μ—ˆμŠ΅λ‹ˆλ‹€.
이런 생각을 가지고 μžˆλ‹€ λ³΄λ‹ˆ λ‹Ήμ—°νžˆ λΉŒλ“œ 해봐야 ν•œλ‹€κ³  μƒκ°ν–ˆλŠ”λ°μš”.

ν˜„μ„λ‹˜μ΄ μ§ˆλ¬Έμ£Όμ‹  λ‚΄μš© 보고 μƒκ°ν•΄λ³΄λ‹ˆ, preview 둜 λ‹¨μˆœ UI λ…ΈμΆœμ„ κΈ°λŒ€ν•˜μ§€, μœ„μ™€ 같은 과정을 κΈ°λŒ€ν• κ±°λΌ μƒκ°λ˜μ§€ μ•Šλ„€μš”.
이런 μΌ€μ΄μŠ€λΌλ©΄, 프리뷰 λ³΄λ‹€λŠ” ViewModel ν…ŒμŠ€νŠΈλ‘œ μ§„ν–‰ν•˜λŠ”κ²Œ 더 적절 ν•˜λ‹€κ³  생각이 λ“€μ—ˆμŠ΅λ‹ˆλ‹€.

λ˜λŠ”, RespoitoryState μƒνƒœμ— λ”°λ₯Έ 화면을 λ³΄μ—¬μ£ΌλŠ” 것이닀 λΌλŠ” κ±Έ ν‘œν˜„ν•  수 μžˆλŠ” λ‹€λ₯Έ 넀이밍이 μ’‹κ² λ‹€ λΌλŠ” 생각도 λ“€μ—ˆμŠ΅λ‹ˆλ‹€.

프리뷰λ₯Ό μ’€ 더 ν”„λ¦¬λ·°λ‘œ ν™œμš©ν•˜κ±°λ‚˜,
λ³΅μž‘ν•œ ν”„λ¦¬λ·°μ˜ 경우 더 λͺ…μ‹œμ μΈ 넀이밍 λ˜λŠ” 상세 μ„€λͺ…이 ν•„μš”ν•˜λ‹€κ³  λŠκΌˆμŠ΅λ‹ˆλ‹€.

λ‹€μ‹œ ν•œ 번 생각 ν•΄λ³Ό 수 있게 질문 μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€.

@BeokBeok
Copy link

κΆκΈˆν•œ 점이 ν•˜λ‚˜ μžˆμŠ΅λ‹ˆλ‹€.
ν”„λ‘œκ·Έλž˜λ° μš”κ΅¬ 사항 쀑에, κΈ°λŠ₯ μš”κ΅¬ 사항에 λŒ€ν•œ UI ν…ŒμŠ€νŠΈλ₯Ό μž‘μ„±ν•œλ‹€ λΌλŠ” λ‚΄μš©μ΄ μžˆμ—ˆλŠ”λ°μš”.
UI ν…ŒμŠ€νŠΈ μž‘μ„±ν•˜λ‹€ λ³΄λ‹ˆ, μΌ€μ΄μŠ€ λ³„λ‘œ κ΅¬ν˜„ν•œ Preview 와 ν…ŒμŠ€νŠΈ μΌ€μ΄μŠ€κ°€ λ™μΌν•΄μ„œ UI ν…ŒμŠ€νŠΈλŠ” μž‘μ„±ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.
UI ν…ŒμŠ€νŠΈλŠ” λ‘œμ§μ„ κ²€μ¦ν•˜μ§€ μ•Šκ³ , λ…ΈμΆœμ— 쀑점을 λ‘”λ‹€λŠ” μˆ˜μ—… λ‚΄μš©μ„ 미루어 봀을 λ•Œλ„, ν•„μš” μ—†μ–΄ λ³΄μž…λ‹ˆλ‹€.
ν˜„μ„λ‹˜μ˜ 생각은 어떠신지 κΆκΈˆν•©λ‹ˆλ‹€.

@ethanchaee
쒋은 μ§ˆλ¬Έμ΄μ‹­λ‹ˆλ‹€! πŸ™‡
이번 λ―Έμ…˜μ„ μ§„ν–‰ν•˜μ‹œλ©΄μ„œ UI ν…ŒμŠ€νŠΈκ°€ ν•„μš”μ—†λ‹€λŠ” 생각을 ν•˜μ‹€ 수 μžˆμ„ 것 κ°™μŠ΅λ‹ˆλ‹€.
ν•˜μ§€λ§Œ, Previewκ°€ UI ν…ŒμŠ€νŠΈλ₯Ό λŒ€μ²΄ν•  μˆ˜λŠ” μ—†λ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€.
UI ν…ŒμŠ€νŠΈμ™€ Preview의 λͺ©μ μ€ μ„œλ‘œ λ‹€λ₯΄κΈ° λ•Œλ¬Έμž…λ‹ˆλ‹€.
κ°€μž₯ 큰 차이점은 μœ μ¦ˆμΌ€μ΄μŠ€ 검증 κ°€λŠ₯ μ—¬λΆ€κ°€ 될 것 κ°™μŠ΅λ‹ˆλ‹€. πŸ™‡

Copy link

@BeokBeok BeokBeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν”Όλ“œλ°± λ°˜μ˜ν•˜μ‹œλŠλΌ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. πŸ‘
μΆ”κ°€λ‘œ κ³ λ―Όν•΄λ³Όλ§Œν•œ μ˜κ²¬λ“€μ„ μ½”λ§¨νŠΈλ‘œ μž‘μ„±ν•˜μ˜€μœΌλ‹ˆ, μΆ©λΆ„νžˆ κ³ λ―Όν•΄λ³΄μ‹œκ³  λ„μ „ν•΄λ³΄μ„Έμš”. πŸ’ͺ
λ‹€μŒ λ―Έμ…˜μ„ μ§„ν–‰ν•˜μ‹œλ©΄μ„œ, μΆ”κ°€λ‘œ μž‘μ„±λœ μ½”λ§¨νŠΈλ“€λ„ λ°˜μ˜ν•΄μ£Όμ„Έμš”. πŸ™

@BeokBeok BeokBeok merged commit 4158d5a into next-step:ethanchaee Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants