Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added past code #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added past code #1

wants to merge 2 commits into from

Conversation

emilyzfliu
Copy link

i tried pushing a branch directly to neuronets but it says access denied, would it be preferable to still use branches in the future?

@satra
Copy link
Contributor

satra commented Dec 4, 2020

PRs are the best way to review code instead of pushing directly. the branch can live in your fork.

await load_weights(client_id)

async def fed_avg():
await load_data()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await load_data()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can load the weights in the for loop below.

self.assertAllClose(model.model.trainable,
iterative_process.get_model_weights(model).trainable)

for _ in range(num_clients):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load the weights for the latest submitted model from each client inside this loop.

@emilyzfliu
Copy link
Author

i think i implemented most of the changes from fedavg.py onto dwc_server.py, right now my main question is how do i make sure the dwc code only runs after there's enough client models loaded and how to save/load the priors from the models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants