Skip to content

Update BrainGlobe info #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Update BrainGlobe info #15

merged 5 commits into from
Jan 5, 2023

Conversation

adamltyson
Copy link
Member

Fixes #12

@adamltyson adamltyson requested a review from a team January 3, 2023 13:51
@adamltyson
Copy link
Member Author

@niksirbi do you know why the build is failing?

@niksirbi
Copy link
Member

niksirbi commented Jan 3, 2023

@niksirbi do you know why the build is failing?

Not yet, but will investigate.

Copy link
Member

@JoeZiminski JoeZiminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me

@niksirbi
Copy link
Member

niksirbi commented Jan 5, 2023

This repo was using an older version of the GitHub actions. I updated to the newer version (the one in our NIU actions repo), but the problem persists.

I have a strong suspicion this is due to the release of Sphinx v6 (on Dec 29 2022). Local build with sphinx v5.3 still works.
A quick fix would be to contain the dependencies to Sphinx <6, but I would like to find out what the actual problem is

@niksirbi
Copy link
Member

niksirbi commented Jan 5, 2023

Constraining the Sphinx version to 5 in requirements fixes the problem for now. I'm afraid we have to do that for all repositories using the check-docs action.
I think the underlying problem has to do with the sphinx base image used by that action, which hasn't been updated for a while. See this PR)

@adamltyson
Copy link
Member Author

Hmm. Annoying, but seems like the best solution for now. Thanks for digging deeper @niksirbi. Are you happy to merge this now, and track the ongoing issue with the action separately?

@niksirbi
Copy link
Member

niksirbi commented Jan 5, 2023

Yeap. I will merge this and open an issue on the actions repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content to brainglobe project description page
3 participants