Added U-turn detection function (issue #362) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accumulated rotation angle to judge
VascoSch92
reviewed
Mar 22, 2025
Make the error message more detailed Co-authored-by: Vasco Schiavo <[email protected]>
Avoid long lines
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 28 28
Lines 1568 1579 +11
=======================================
+ Hits 1566 1577 +11
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Angelneer926, you may have noticed some CI checks are not passing. It seems some added lines of code are not covered by tests. Would you mind investigating this? As per our guidelines, all our code contributions should be fully tested. Thanks! |
Add a test of Value Error,
for more information, see https://pre-commit.ci
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an U-turn detection function.
Description
What is this PR
Why is this PR needed?
This PR implements U-turn detection, as requested in issue #362.
What does this PR do?
Using the extreme value difference of the accumulated rotation angle to judge. (support setting extreme value threshold)
References
#362
How has this PR been tested?
The new code has been tested using a fixture that provides a mock dataset for U-turn detection, ensuring that the function detect_u_turns works correctly for both "forward_vector" and "displacement" directions. Tests also verify that the U-turn detection results match the expected values, with results under different thresholds all meeting the expectations.
Is this a breaking change?
No
Does this PR require an update to the documentation?
The docstring has been updated to explain the new detection method and parameters.
Checklist: