Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-2071 CLI use cases for 1.8 #6

Merged
merged 33 commits into from
Feb 14, 2025

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 28, 2025

Updated concrete scenarios with 1.8 commands

  • added north south / east west using subnets
  • added UDN as tech preview

@msherif1234
Copy link
Contributor

maybe adding a usecase with filter on drop flows as that was one of the use cases we heard during f2f ?

@msherif1234
Copy link
Contributor

also another use case if watching N/S flows only or E/W flows only

You can cycle to different views using left / right arrow keys and change the displayed enrichment colomns using page up / down ones.
Also, to adapt to your screen height, you can increase / decrease the number of displayed flows using up / down arrow keys.

In this capture, we see that the traffic is blocked by OVS since it reports the `OVS_DROP_LAST_ACTION` drop cause. This probably means that a Network Policy is involved.
Copy link
Contributor

@msherif1234 msherif1234 Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff no longer available with network events support, u will use network events feature and look for drops actions instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I can rerun this scenario and see how it goes. I'm supposed to get both drop info + event here ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no drop for netpol just event, ovs team has dropped the drop cause when they created the new events hook they said we can't have both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means this will not displayed in overview drop cause graph anymore !

We may need a new graph for events here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will get still pkt drops but not for ovn netpol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't get anything in the drops info in that case
Screenshot from 2025-02-03 11-32-07

Whereas the events are correct:
Screenshot from 2025-02-03 11-31-45

It's really confusing in terms of UX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listed the two cases in 152644b

cc @jotak we should be good to publish now 😸

Copy link

github-actions bot commented Feb 3, 2025

🙈 The PR is closed and the preview is expired.

@jpinsonneau
Copy link
Contributor Author

also another use case if watching N/S flows only or E/W flows only

Added this in f958c46

Once some traffic is captured, the output will look like:
![cli network events]({page.image('cli/connectivity-scenario-cli-events.png')})

Cycle to the **network events** view. In this capture, we see that the traffic is blocked by a network policy since it reports the `NetpolNamespace` event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should provide a better output for the network events

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Do you have a screen ?
Else I will spin up a cluster

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, cluster not started yet

Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for letting me review. I left some feedback, mostly copy edits :)

@jpinsonneau
Copy link
Contributor Author

Nice work! Thanks for letting me review. I left some feedback, mostly copy edits :)

Thanks for the very detailed review @skrthomas ! that's awesome !
I updated the PR to use present tense: a22f3f9

jpinsonneau and others added 25 commits February 14, 2025 13:41
Co-authored-by: Amogh Rameshappa Devapura <[email protected]>
@jpinsonneau
Copy link
Contributor Author

Rebased without changes to see if the preview works now

@jpinsonneau jpinsonneau merged commit 4b7d292 into netobserv:main Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants