-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-2092 Inject drop events in drop fields #587
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
for _, event := range fr.NetworkMonitorEventsMD { | ||
// override drop fields when network event action is dropped | ||
if event["Action"] == "drop" { | ||
out["PktDropBytes"] = fr.Metrics.Bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right the same flow could be going through allow ingress and drop egress events ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have the amount of packets / bytes from the event ?
Previously we had these amounts of drops. This is displayed in the plugin + dashboards so it would be very useful to get that back somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not a single event same flow can have allow and deny event or 2 allow and 1 deny or any other combo so hard to tell, the drop we had will still work for everything else except netpol and adminnetpol right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes of course but the goal here is to be able to make graphs with the amount of bytes / packets / flows denied because of policies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how @jotak managed it for now: netobserv/network-observability-operator#863 + netobserv/flowlogs-pipeline#739
This is showing events rates. I'm not sure it's relevent for the user.
The console plugin could rely on prometheus for these but will not be able to query loki without extra processing
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Force OVS_DROP cause when received a drop event.
Also set dropped bytes and packets to have proper metrics.
Original discussion: netobserv/netobserv.github.io#6 (comment)
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.