chore: add more test coverage for edge function tarball bundling #6745
+1,131
−262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
JakeChampion
force-pushed
the
jake/build
branch
from
ba1adb4 to
f408b0b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the edge functions test suite to run all tests with multiple flag variants, specifically adding support for testing both default behavior and tarball generation. The changes enable comprehensive testing of the edge_bundler_generate_tarball feature flag.
Key changes:
- Introduced a parameterized testing approach using
FLAG_VARIANTSto run all tests with different flag configurations - Added
assertBundlesExisthelper to verify the correct bundle formats are generated based on the variant - Updated all test names to include the variant ID prefix (e.g., "default -" or "tarball -")
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/build/tests/edge_functions/tests.js | Wrapped all edge function tests in a loop over FLAG_VARIANTS, added bundle format assertions, and improved test cleanup with try-finally blocks |
| packages/build/tests/edge_functions/snapshots/tests.js.snap | Binary snapshot file updated with new test outputs for both default and tarball variants |
| packages/build/tests/edge_functions/snapshots/tests.js.md | Human-readable snapshots updated to include both default and tarball variant outputs for all tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JakeChampion
force-pushed
the
jake/build
branch
4 times, most recently
from
e79b1ed to
082ea16
Compare
JakeChampion
force-pushed
the
jake/build
branch
6 times, most recently
from
f5c7556 to
9897380
Compare
updating our existing edge function tests to run with both default (eszip2) and tarball bundling configurations using feature flag variants
JakeChampion
force-pushed
the
jake/build
branch
from
9897380 to
8310892
Compare
eduardoboucas
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating our existing edge function tests to run with both default (eszip2) and tarball bundling configurations using feature flag variants
This is easier to review with the github ignore whitespace diff view enabled -- https://github.com/netlify/build/pull/6745/files?w=1