Fix: the 'smgropen' in the 'calculate_relation_size' function may return an incorrect 'smgrRelation' #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn an incorrect 'smgrRelation'
|
I have created a team task for us to review your PR. Thanks for contributing! |
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Jan 24, 2025
## Problem Parent of partitioned table has no storage, it relfilelocator is zero. It cab be incorrectly hashed and produce wrong results. See neondatabase/postgres#518 ## Summary of changes This problem is already addressed in pg17. Add the same check for all other PG versions. Postgres PRs: neondatabase/postgres#566 neondatabase/postgres#565 neondatabase/postgres#564 Co-authored-by: Konstantin Knizhnik <[email protected]>
|
@knizhnik fixed it in neondatabase/neon#10477 in a slightly different way, so I'm closing this one. We still really appreciate your contribution, @Lzjing-1997, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steps to reproduce:
postgres=# create table sa(a int) partition by range(a);
CREATE TABLE
postgres=# create unlogged table sb(b int) partition by range(b);
CREATE TABLE
postgres=# select pg_relation_size('sa'), pg_relation_size('sb');
ERROR: relpersistence mismatch: smgropen u vs SmgrRelation p
For a partitioned table, the relfilenode of its parent table is always 0 ; 'smgropen' in function 'calculate_relation_size' may get incorrect 'smgrRelation' due to 'SMgrRelationHash'.