Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if relation has storage in calculate_relation_size #10477

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

knizhnik
Copy link
Contributor

Problem

Parent of partitioned table has no storage, it relfilelocator is zero.
It cab be incorrectly hashed and produce wrong results.

See neondatabase/postgres#518

Summary of changes

This problem is already addressed in pg17.
Add the same check for all other PG versions.

Postgres PRs:
neondatabase/postgres#566
neondatabase/postgres#565
neondatabase/postgres#564

@knizhnik knizhnik requested a review from a team as a code owner January 22, 2025 12:41
@knizhnik knizhnik requested review from hlinnaka, myrrc and MMeent January 22, 2025 12:41
Copy link

github-actions bot commented Jan 22, 2025

7403 tests run: 7015 passed, 0 failed, 388 skipped (full report)


Flaky tests (7)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 33.5% (8498 of 25347 functions)
  • lines: 49.3% (71482 of 144985 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
973beb4 at 2025-01-24T11:37:24.475Z :recycle:

@knizhnik knizhnik force-pushed the partitioned_dbsize_fix branch from 2c76247 to 0f63d66 Compare January 22, 2025 19:14
Copy link
Contributor

@MMeent MMeent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it needs some applied conflict resolution w.r.t. /vendor, but apart from that LGTM.

@knizhnik knizhnik force-pushed the partitioned_dbsize_fix branch from 0f63d66 to 973beb4 Compare January 24, 2025 10:19
@knizhnik knizhnik added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit d8ab6dd Jan 24, 2025
87 checks passed
@knizhnik knizhnik deleted the partitioned_dbsize_fix branch January 24, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants