Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WV-3459 Charting Release #5676

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

WV-3459 Charting Release #5676

wants to merge 7 commits into from

Conversation

christof-wittreich
Copy link
Contributor

@christof-wittreich christof-wittreich commented Jan 31, 2025 •
edited
Loading

Description

This change adds a more clear error message when the chart request fails, and allows charting options to be included in permalinks. It also adds multiple changes based on feedback about the function of the entire mode, including both UI updates and functionality updates.

How To Test

  1. git checkout wv-3459-charting-error-message
  2. npm run build
  3. npm ci
  4. npm run watch
  5. Open a fresh instance of Worldview
  6. Add multiple layers that can be used for charting, such as OMI_Aerosol_Index and MODIS_Combined_Value_Added_AOD
  7. Open the charting interface via the 'Start Charting' button
  8. Select which layer is selected for charting, change the dates, select an AOI, and generate a chart
  9. Reload the page with the chart still open, and verify that the page re-requests that chart with the same parameters and options automatically on reload
  10. Verify that changing the charting options to other options and reloading the page works as well
  11. Very that changing the AOI updates the coordinates, and vice versa
  12. Verify that charting continues to work correctly

@christof-wittreich christof-wittreich self-assigned this Jan 31, 2025
@christof-wittreich
Initial feedback changes
6a148c4
@christof-wittreich
Squashed commit of the following:
2be276c 
commit 509562c
Author: minniewong <[email protected]>
Date:   Fri Feb 7 08:47:02 2025 -0500

    Update start date and allow image snapshot of L3 layers (#5682)

    * Update start date and allow image snapshot of L3 layers

    * Update start time for L3 TEMPO layers

commit 234be74
Merge: 9642ae7 8f9cbf6
Author: Patrick Moulden <[email protected]>
Date:   Wed Feb 5 10:11:27 2025 -0500

    Merge pull request #5684 from nasa-gibs/main

    main into develop

commit 8f9cbf6
Merge: 1dcfbf1 94d9b8a
Author: Patrick Moulden <[email protected]>
Date:   Wed Feb 5 09:33:33 2025 -0500

    Merge pull request #5683 from nasa-gibs/release

    Release into main

commit 94d9b8a
Merge: c2fe750 07dce6d
Author: Patrick Moulden <[email protected]>
Date:   Tue Feb 4 16:22:01 2025 -0500

    Merge pull request #5681 from nasa-gibs/UAT-v4.56.1

    UAT v4.56.1 to Release

commit 07dce6d
Author: Patrick Moulden <[email protected]>
Date:   Tue Feb 4 15:12:47 2025 -0500

    v4.56.1

commit 9642ae7
Author: Patrick Moulden <[email protected]>
Date:   Tue Feb 4 14:27:17 2025 -0500

    Resolve checks 02-04-2024 (#5680)

    * Rebuild package-lock.json

    * Update jest.config.js to include 'color-name' in transformIgnorePatterns

commit e7dead8
Merge: 693f70a 1dcfbf1
Author: Patrick Moulden <[email protected]>
Date:   Tue Feb 4 08:38:43 2025 -0500

    Merge pull request #5679 from nasa-gibs/main

    main into develop

commit 1dcfbf1
Merge: 86a3e3e c2fe750
Author: Patrick Moulden <[email protected]>
Date:   Mon Feb 3 15:05:31 2025 -0500

    Merge pull request #5678 from nasa-gibs/release

    Release into main

commit c2fe750
Merge: 8a1e6fd 86a3e3e
Author: Patrick Moulden <[email protected]>
Date:   Mon Feb 3 15:01:31 2025 -0500

    Merge branch 'main' into release

commit 8a1e6fd
Merge: 286e9e8 1df576f
Author: Patrick Moulden <[email protected]>
Date:   Mon Feb 3 11:48:10 2025 -0500

    Merge pull request #5677 from nasa-gibs/UAT-v4.56.0

    UAT-v4.56.0 to Release

commit 1df576f
Merge: 229a937 286e9e8
Author: Patrick Moulden <[email protected]>
Date:   Mon Feb 3 11:08:14 2025 -0500

    Merge branch 'release' into UAT-v4.56.0

commit 229a937
Author: Patrick Moulden <[email protected]>
Date:   Mon Feb 3 11:03:05 2025 -0500

    v4.56.0

commit 693f70a
Author: Patrick Moulden <[email protected]>
Date:   Fri Jan 31 16:57:53 2025 -0500

    WV-3463 Implement connection to NOAA WMTS for Maxar imagery (#5668)

    * Add NOAA 2025 ERI WMTS layer and update configurations

    * Add layer description, preview image, disaster response measurement

    * Update layer count in layer picker test to reflect recent changes

    * Update for Jan 28 imagery

    * Increase number of zoom levels in geographic projection configuration

    * Refactor mapLayerBuilder to remove unnecessary comments

    * Enhance tile source configuration by adding additional zoom levels and matrix sizes

    ---------

    Co-authored-by: minniewong <[email protected]>

commit 2b048e6
Author: minniewong <[email protected]>
Date:   Fri Jan 31 16:18:35 2025 -0500

    WV-3473: Update HLS Sentinel-2 and Landsat descriptions (#5674)

    * Add Sentinel-2C information

    * Updates to Landsat and Sentinel-2 descriptions

commit fbf90ac
Author: minniewong <[email protected]>
Date:   Fri Jan 31 15:24:12 2025 -0500

    WV-3198: Add TEMPO Ozone (UV Aerosol Index) layers (#5673)

    * Add TEMPO UVAI

    * Update layerOrder.json

    * Update preview images

    * Update layer-picker-test.spec.js

    * Update layer-picker-test.spec.js

    * Update layer-picker-test.spec.js

commit 4a509cb
Author: christof-wittreich <[email protected]>
Date:   Fri Jan 31 13:40:33 2025 -0500

    Dependency Updates 01-31-25 (#5675)

commit 86a3e3e
Author: christof-wittreich <[email protected]>
Date:   Wed Jan 22 16:58:06 2025 -0500

    Revert "Merge branch 'develop' into main"

    This reverts commit ac04138, reversing
    changes made to 683662a.

commit ac04138
Merge: 683662a c27a5b5
Author: christof-wittreich <[email protected]>
Date:   Wed Jan 22 16:56:57 2025 -0500

    Merge branch 'develop' into main

commit 683662a
Merge: d64fff0 286e9e8
Author: christof-wittreich <[email protected]>
Date:   Wed Jan 22 16:49:26 2025 -0500

    Merge pull request #5665 from nasa-gibs/release

    Release to Main v4.55.1

commit 286e9e8
Merge: f357522 28e4458
Author: christof-wittreich <[email protected]>
Date:   Wed Jan 22 16:17:32 2025 -0500

    Merge pull request #5664 from nasa-gibs/UAT-v4.55.1

    UAT-v4.55.1 to Release

commit 28e4458
Author: christof-wittreich <[email protected]>
Date:   Wed Jan 22 15:50:51 2025 -0500

    Fixed package-lock

commit 5c814fa
Author: christof-wittreich <[email protected]>
Date:   Wed Jan 22 15:47:16 2025 -0500

    v4.55.1

commit 17e62c6
Author: minniewong <[email protected]>
Date:   Wed Jan 22 15:41:40 2025 -0500

    This effort was done on NASA direction on 01/22/2025 (#5663)
Tomcariello
Tomcariello approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Tomcariello Tomcariello left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To anyone testing, make sure you change features.charting: true in config\default\common\features.json prior to building.

We need to strongly consider a progress/status bar, especially with the chart request on permalink. Users are not going to know they need to wait a few seconds unless we make that clear.

@christof-wittreich christof-wittreich changed the title WV-3459 Charting Error Message and Permalinking WV-3459 Charting Release Feb 13, 2025
@minniewong minniewong added this to the v4.59.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomcariello Tomcariello Tomcariello approved these changes

@PatchesMaps PatchesMaps Awaiting requested review from PatchesMaps

@minniewong minniewong Awaiting requested review from minniewong

Assignees

@christof-wittreich christof-wittreich

Labels
None yet
Projects
None yet
Milestone
v4.59.0
Development

Successfully merging this pull request may close these issues.
3 participants
@christof-wittreich @Tomcariello @minniewong