Merge generics support in mscorlib #245
Conversation
- Publish to nuget now happens on build from develop branch too.
- Temporary disable trigger for tags. ***NO_CI***
- Fix parameter name. - Add branch to publish nugets from. ***NO_CI***
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughCI pipeline and versioning were updated: azure-pipelines.yml changes template parameters, variables, triggers, and release conditions; a new template was added to extract nanoCLR build IDs from PRs and optionally download artifacts; version.json switched to semantic preview versioning and added a branch pattern. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant AP as AzurePipelines
participant GH as GitHub
participant Art as ArtifactStorage
Dev->>AP: Push / open PR
AP->>AP: Start pipeline
alt PR present
AP->>AP: Run check-nf-interpreter-to-test template
AP->>GH: GET /repos/.../pulls/{PR} (auth: GITHUB_TOKEN)
GH-->>AP: PR payload (body)
AP->>AP: Verify PR number, extract buildId via regex
alt buildId found and DownloadNanoClrPreview = true
AP->>Art: Download nanoCLR artifact (by buildId)
Art-->>AP: artifact (nanoCLR dll)
AP->>AP: Set NF_MDP_NANOCLR_INSTANCE_PATH variable
else
AP-->>AP: Skip download
end
end
AP->>AP: Run class-lib-build-only (usePreviewBuild: true)
AP->>AP: Run class-lib-publish (baseBranchName: develop)
AP->>AP: Read version.json (2.0.0-preview.{height})
AP->>AP: Evaluate release condition (branch main or develop, not StartReleaseCandidate)
alt release conditions satisfied
AP->>GH: Create GitHub release (isPreRelease when branch is develop)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
azure-pipelines.yml (2)
59-60: Remove duplicate variable declaration & trailing spaces.You’ve declared
DOTNET_NOLOGOboth globally (lines 36–37) and again under theBuild_mscorlibjob. This duplication is unnecessary and may lead to confusion. Also, YAMLlint flagged trailing spaces on line 60.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 60-60: trailing spaces
(trailing-spaces)
132-136: Consider adding thegenericsbranch to release conditions.You’ve broadened the GitHub release condition to run on
mainanddevelop. To stay consistent with the newpublicReleaseRefSpec, you might also includegenericshere if you intend to create releases from that branch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
.runsettingsis excluded by none and included by noneTests/NFUnitTestGC/TestGC.csis excluded by none and included by noneTests/NFUnitTestSystemLib/UnitTestGCTest.csis excluded by none and included by noneTests/NFUnitTestSystemLib/UnitTestInitLocalTests.csis excluded by none and included by noneTests/NFUnitTestSystemLib/UnitTestReflectionTypeTest.csis excluded by none and included by noneTests/UnitTestLauncher/UnitTestLauncher.nfprojis excluded by none and included by nonenanoFramework.CoreLibrary.nuspecis excluded by none and included by nonenanoFramework.CoreLibrary/System/AssemblyInfo.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/GC.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/Guid.csis excluded by none and included by nonenanoFramework.TestFrameworkis excluded by none and included by none
📒 Files selected for processing (2)
azure-pipelines.yml(3 hunks)version.json(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
azure-pipelines.yml
[error] 60-60: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: nanoframework.CoreLibrary (Build_mscorlib)
- GitHub Check: nanoframework.CoreLibrary (Build_mscorlib)
🔇 Additional comments (4)
version.json (2)
3-3: Approve semantic version update.Updating the base version to
"2.0.0-preview.{height}"correctly switches to semantic versioning with a preview suffix. This aligns with the pipeline change enabling preview builds.
14-14: Approve new public release branch pattern.Adding
^refs/heads/generics$topublicReleaseRefSpecensures the newly merged “generics” branch is considered for public releases.azure-pipelines.yml (2)
79-79: Verify template supportsusePreviewBuild.You’ve enabled
usePreviewBuild: truein theclass-lib-build-only.ymlinvocation. Please confirm that the template accepts and correctly propagates this parameter to invoke preview-mode builds as expected.
122-125: Ensure publish step aligns with new branches.The
class-lib-publish.ymltemplate is now called withbaseBranchName: 'develop'. Given thatversion.jsonincludes agenericsbranch for public releases, please verify whetherbaseBranchNameshould dynamically reflectgenerics(or accept a list of branches) to fully support that branch.
|
…nto develop ***NO_CI***
- Add target for .NET Framework v4.7.2
|
…nto develop ***NO_CI***
(cherry picked from commit 81808e5)
***NO_CI***
- Remove unexistent var from conditions. ***NO_CI***
- Improve download and usage of specific nanoCLR from nf-interpreter build. ***NO_CI***
- Build now uses NuGet cache again. ***NO_CI***
***NO_CI***
|
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
Chores
New Features