Skip to content

Fixes for TypeRef of generic types #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Fixes for TypeRef of generic types #3182

merged 1 commit into from
Jun 18, 2025

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 17, 2025 •
edited
Loading

Description

  • Fix handler for CEE_CALL and CEE_CALVIRT: now checks if callee is a value type and skips resolving it.
  • Add ownerType to CLR_RT_TypeSpec_CrossReference.
  • Add new return parameter to FindMethodDef so assembly index is returned upon finding.
  • Add new CLR_RT_MethodDef_Instance.InitializeFromIndex() taking a TypeSpec to deal with generic types.
  • Add new CLR_RT_MethodDef_Instance.GetDeclaringType() helper to take advantage of pre-processed type.
  • Rework CLR_RT_Assembly::FindTypeSpec() to handle generic types referenced in other assembly.
  • Various fixes in build type and method names to deal with generic types referenced in other assembly.
  • CLR_RT_Assembly::FindMethodDef() now returns assembly index of method upon succesfull finding.
  • Fix CLR_RT_GenericParam_Instance::InitializeFromIndex() to deal with generic types referenced in other assembly.
  • Fix CLR_RT_MethodDef_Instance::ResolveToken() to deal with generic types referenced in other assembly.
  • CLR_RT_SignatureParser::Advance() now sets datatype for classes and value types.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes added the Area: Interpreter Everything related with the interpreter, execution engine and such label Jun 17, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@josesimoes josesimoes force-pushed the fix-typeref-generics branch from eafe9cb to bb0bdb1 Compare June 17, 2025 22:59
@josesimoes
Fixes for TypeRef of generic types
f774058 
- Fix handler for CEE_CALL and CEE_CALVIRT: now checks if callee is a value type and skips resolving it.
- Add ownerType to CLR_RT_TypeSpec_CrossReference.
- Add new return parameter to FindMethodDef so assembly index is returned upon finding.
- Add new CLR_RT_MethodDef_Instance.InitializeFromIndex() taking a TypeSpec to deal with generic types.
- Add new CLR_RT_MethodDef_Instance.GetDeclaringType() helper to take advantage of pre-processed type.
- Rework CLR_RT_Assembly::FindTypeSpec() to handle generic types referenced in other assembly.
- Various fixes in build type and method names to deal with generic types referenced in other assembly.
- CLR_RT_Assembly::FindMethodDef() now returns assembly index of method upon succesfull finding.
- Fix CLR_RT_GenericParam_Instance::InitializeFromIndex() to deal with generic types referenced in other assembly.
- Fix CLR_RT_MethodDef_Instance::ResolveToken() to deal with generic types referenced in other assembly.
- CLR_RT_SignatureParser::Advance() now sets datatype for classes and value types.
@josesimoes josesimoes force-pushed the fix-typeref-generics branch from bb0bdb1 to f774058 Compare June 17, 2025 23:45
@josesimoes josesimoes merged commit d3f7c34 into nanoframework:develop Jun 18, 2025
24 checks passed
@josesimoes josesimoes deleted the fix-typeref-generics branch June 18, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot