pbrt: encode backward, use C stubs #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-cube
force-pushed
the
wip-encode-backward-with-c-stubs
branch
2 times, most recently
from
1b0ce2b to
b20dab0
Compare
c-cube
force-pushed
the
wip-typecheck-services
branch
from
58a1db6 to
c1c8392
Compare
also update code-generation so it writes values backward.
run exactly one encoding per iteration, do better checks
we preallocate the encoder. Actual encoding time is more interesting because in high perf situations we'll reuse allocators.
it's no alloc, so as @Armael pointed out we don't need the CAML*** macros
c-cube
force-pushed
the
wip-encode-backward-with-c-stubs
branch
from
b20dab0 to
f8dc50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.