Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visitor pattern for pbrt encoder #221

Closed
wants to merge 5 commits into from
Closed

visitor pattern for pbrt encoder #221

wants to merge 5 commits into from

Conversation

c-cube
Copy link
Collaborator

@c-cube c-cube commented Nov 22, 2023

The goal is to make encoding more flexible (ability to encode to bigarrays, etc.) and also to permit to encode backwards eventually.

@c-cube c-cube changed the base branch from master to wip-typecheck-services November 22, 2023 06:59
@c-cube
Copy link
Collaborator Author

c-cube commented Nov 24, 2023

This is not a great idea, compared to #222 which achieves good performance.

@c-cube c-cube closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c-cube