Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency base62 to v2 #7077

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Update dependency base62 to v2 #7077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd05c8
Update dependency base62 to v2
renovate-bot Nov 27, 2018
1dc2eed
Check for NaN too
willdurand Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
"homepage": "https://github.com/mozilla/addons-frontend#readme",
"dependencies": {
"@babel/polyfill": "7.0.0",
"base62": "1.2.8",
"base62": "2.0.0",
"base64url": "3.0.1",
"better-npm-run": "0.1.1",
"chokidar": "2.0.4",
Expand Down
4 changes: 2 additions & 2 deletions src/amo/components/App/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ export class AppBase extends React.Component<Props> {
);
return;
}
// If the encoded timestamp was malformed it will be 0 or negative.
if (createdAt <= 0) {
// If the encoded timestamp was malformed it will be NaN, 0 or negative.
if (Number.isNaN(createdAt) || createdAt <= 0) {
log.error(oneLine`Got an invalid timestamp from auth token;
encoded value: ${encodedTimestamp}; decoded value: ${createdAt}`);
return;
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3363,10 +3363,10 @@ balanced-match@^1.0.0:
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-1.0.0.tgz#89b4d199ab2bee49de164ea02b89ce462d71b767"
integrity sha1-ibTRmasr7kneFk6gK4nORi1xt2c=

base62@1.2.8:
version "1.2.8"
resolved "https://registry.yarnpkg.com/base62/-/base62-1.2.8.tgz#1264cb0fb848d875792877479dbe8bae6bae3428"
integrity sha512-V6YHUbjLxN1ymqNLb1DPHoU1CpfdL7d2YTIp5W3U4hhoG4hhxNmsFDs66M9EXxBiSEke5Bt5dwdfMwwZF70iLA==
base62@2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/base62/-/base62-2.0.0.tgz#62292693fb0418824caaae6dc19d01fe8bdd9691"
integrity sha512-s3DXUcvJVW9vd9L/iahft3cxsrBQsXfG0ktX/uzkKOO7ZHHE8Lw3mP+rSXb7YzVavX+fB1jX1GFHDfI/NX8/SQ==

base64-js@^1.0.2:
version "1.3.0"
Expand Down