Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency base62 to v2 #7077

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Update dependency base62 to v2 #7077

merged 2 commits into from
Nov 28, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 27, 2018

This PR contains the following updates:

Package Type Update Change References
base62 dependencies major 1.2.8 -> 2.0.0 source

Release Notes

andrew/base62.js

v2.0.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


This PR has been generated by Renovate Bot. View repository job log here.

@willdurand
Copy link
Member

Looks like there is (maybe) a regression in the upstream lib: base62/base62.js#75. Let's wait.

@willdurand
Copy link
Member

Looks like there is (maybe) a regression in the upstream lib: andrew/base62.js#75. Let's wait.

So there is no regression per se, the code has been fixed to fix an incorrect behavior.

@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2018

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #7077 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7077      +/-   ##
==========================================
- Coverage    97.9%   97.87%   -0.04%     
==========================================
  Files         253      253              
  Lines        6928     7101     +173     
  Branches     1283     1340      +57     
==========================================
+ Hits         6783     6950     +167     
- Misses        131      137       +6     
  Partials       14       14
Impacted Files Coverage Δ
src/amo/components/App/index.js 98.33% <100%> (ø) ⬆️
src/amo/components/Routes/index.js 30% <0%> (-10%) ⬇️
src/amo/pages/AddonInfo/index.js 95.65% <0%> (-1.02%) ⬇️
src/amo/components/AddonMoreInfo/index.js 100% <0%> (ø) ⬆️
src/amo/pages/AddonReviewList/index.js 100% <0%> (ø) ⬆️
src/core/reducers/versions.js 100% <0%> (ø) ⬆️
src/core/utils/index.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f928a4...1dc2eed. Read the comment docs.

@willdurand willdurand merged commit f63b27b into master Nov 28, 2018
@willdurand willdurand deleted the renovate/base62-2.x branch November 28, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants