linkify all user names on ratings list; handle an account response with undefined fields

[eviljeff]

Fixes mozilla/addons#15403

Shows user account links for all ratings, and hides the fields that won't be present on the user profile page.

profile page

before

(before mozilla/addons#15402 changed the API it would have been a 404)

after

ratings

before

after

[eviljeff]

re: covecov error - I've looked but I'm not sure where I'd be adding tests, exactly (codecov claims some of the existing lines in getFormValues are covered, but can't see where). The changes in getFormValues were only added to stop Flow from complaining about the values being potentially undefined anyway - in reality your own account response will always contain those object keys, as now.

[eviljeff]

Note, the amo api on dev and stage is supposed to be returning an account response that includes all the fields, so it shouldn't be possible to test this with yarn amo:dev, but good news! (as I write) the API_GATE isn't working 🙃 .

[diox]

re: covecov error - I've looked but I'm not sure where I'd be adding tests, exactly (codecov claims some of the existing lines in getFormValues are covered, but can't see where). The changes in getFormValues were only added to stop Flow from complaining about the values being potentially undefined anyway - in reality your own account response will always contain those object keys, as now.

AFAICT you have no tests that simulate biography, occupation, location, homepage etc being undefined when going through UserProfileEdit page. All tests in TestUserProfileEdit.js use createUserAccountResponse() either directly or through dispatchSignInActionsWithStore(), without setting those fields to undefined, so they get the defaults defined in that function. So I'd say codecov complaining about lack of coverage here is warranted.

[diox]

On top of my comment about coverage...

I'm currently seeing, with dev API:

Which doesn't match your "after" screenshot.

[eviljeff]

The after is what it will look like once the shim is disabled for v5 - with the shim enabled some of the fields are still returned.

i think I'll disable the shim for v5 (different ticket) and update when that's live

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (8e6ffaa) to head (f9a6e95).
Report is 20 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #13503   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         267      267           
  Lines       10610    10617    +7     
  Branches     3233     3240    +7     
=======================================
+ Hits        10428    10435    +7     
  Misses        169      169           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[eviljeff]

mozilla/addons-server#23223 removes the shim for v5 - the testing will be accurate after that PR is merged and on addons-dev