Skip to content

Ignore X.509 users in scram secret collision validation #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore X.509 users in scram secret collision validation #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions controllers/validation/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,18 @@ func validateUsers(mdb mdbv1.MongoDBCommunity) error {
connectionStringSecretNameMap[connectionStringSecretName] = user
}

// Ensure no collisions in the secret holding scram credentials
scramSecretName := user.ScramCredentialsSecretName
if previousUser, exists := scramSecretNameMap[scramSecretName]; exists {
scramSecretNameCollisions = append(scramSecretNameCollisions,
fmt.Sprintf(`[scram secret name: "%s" for user: "%s" and user: "%s"]`,
scramSecretName,
previousUser.Username,
user.Username))
} else {
scramSecretNameMap[scramSecretName] = user
if user.Database != constants.ExternalDB {
// Ensure no collisions in the secret holding scram credentials
scramSecretName := user.ScramCredentialsSecretName
if previousUser, exists := scramSecretNameMap[scramSecretName]; exists {
scramSecretNameCollisions = append(scramSecretNameCollisions,
fmt.Sprintf(`[scram secret name: "%s" for user: "%s" and user: "%s"]`,
scramSecretName,
previousUser.Username,
user.Username))
} else {
scramSecretNameMap[scramSecretName] = user
}
}

if user.Database == constants.ExternalDB {
Expand Down