Ignore X.509 users in scram secret collision validation #1708
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadim Aleksandrov <[email protected]>
verdel
requested review from
mircea-cosbuc,
lsierant,
nammn,
Julien-Ben,
MaciejKaras,
lucian-tosa,
fealebenpae and
m1kola
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
During validation, users without the scramCredentialsSecretName parameter are added to a dictionary with an empty key, which leads to the error mentioned above.
I think we should skip the scram secret collision validation for users authenticated with x509 certificates.
This PR closes #1707 .
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).