fix!: query param serialization/parsing #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
force-pushed
the
mn/fix/query-param-serialization
branch
from
ddea1a2 to
48cb0e4
Compare
mnahkies
added a commit
that referenced
this pull request
Nov 29, 2025
will make it easier to complete #381 by avoiding irrelevant `style` values needing to be considered / filtered.
mnahkies
force-pushed
the
mn/fix/query-param-serialization
branch
2 times, most recently
from
4369e77 to
0ab231b
Compare
mnahkies
commented
Dec 20, 2025
packages/openapi-code-generator/src/typescript/server/server-operation-builder.ts
Show resolved
Hide resolved
| const firstOneOf = schema.oneOf[0] | ||
|
|
||
| if (firstOneOf) { | ||
| logger.error( |
Owner
Author
There was a problem hiding this comment.
Maybe better to just throw an error?
packages/openapi-code-generator/src/typescript/server/server-operation-builder.ts
Outdated
Show resolved
Hide resolved
mnahkies
added a commit
that referenced
this pull request
Dec 22, 2025
introduces a new `typescript-common-runtime` package, and refactors the existing runtime packages to move common functionality into it. this will give us a better place to put code such as the form data request body parsing, and upcoming query string parsing (#381) there are a couple of minor breaking changes: - Drop deprecated exports (not used in regenerated code) - Wrap response validation errors properly when using `joi` BREAKING CHANGE: deprecated exports removed, regenerate using the latest cli to avoid issues
mnahkies
force-pushed
the
mn/fix/query-param-serialization
branch
2 times, most recently
from
6a7ca97 to
b30c1cf
Compare
mnahkies
force-pushed
the
mn/fix/query-param-serialization
branch
from
b30c1cf to
5b1bce5
Compare
mnahkies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
respect the
styleandexplodemodifiers onin: queryparameters.this is required to generate working clients for https://github.com/typesense/typesense-api-spec for example, as it defines the query parameters as a single object that should be "exploded" (eg: flattened) to multiple parameters.
removes the
qsdependency in favor of our own parsing / serialization based on thestyle+explodemodifiers.in addition to the e2e tests in this repository, I've tested the generated clients e2e against a typesense server, which previously didn't work.