feat!: introduce a new common runtime #401
Conversation
| "test": "jest" | ||
| }, | ||
| "dependencies": { | ||
| "@nahkies/typescript-common-runtime": "workspace:^", |
There was a problem hiding this comment.
note: I know that lerna won't update these correctly in peerDependencies (lerna/lerna#3671) - but I think it should be ok for dependencies
to be tested as part of an alpha version publish.
| "import": "./dist/joi.js", | ||
| "types": "./dist/joi.d.ts" | ||
| }, | ||
| "./zod": { |
| return result.value | ||
| return value | ||
| } catch (err) { | ||
| throw ExpressRuntimeError.ResponseError(err) |
There was a problem hiding this comment.
Breaking change: previously joi response validation errors weren't wrapped correctly
| "bugs": { | ||
| "url": "https://github.com/mnahkies/openapi-code-generator/issues" | ||
| }, | ||
| "exports": { |
There was a problem hiding this comment.
Doing a single barrel export didn't work, as for ESM consumers I ran into:
error TS1287: A top-level 'export' modifier cannot be used on value declarations in a CommonJS module when 'verbatimModuleSyntax' is enabled.
I don't fully understand why the same code works fine when exporting individual files like this, but it works 🤷♂️
There was a problem hiding this comment.
these moved files were identical to the ones deleted form the other runtime
mnahkies
force-pushed
the
mn/feat/common-runtime
branch
from
ca511a9 to
40f2cf9
Compare
| @@ -0,0 +1,84 @@ | |||
| { | |||
| "name": "@nahkies/typescript-common-runtime", | |||
There was a problem hiding this comment.
Annoyingly, it looks like I'll have to generate an API token and manually publish the package for the first time, in order to then configure trusted publishing settings properly.
mnahkies
changed the title
introduces a new
typescript-common-runtimepackage, and refactors the existing runtime packages to move common functionality into it.this will give us a better place to put code such as the form data request body parsing, and upcoming query string parsing (#381)
there are a couple of minor breaking changes:
joiBREAKING CHANGE: deprecated exports removed, regenerate using the latest cli to avoid issues