Refactor user config code #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of the existing parsers, this particular C89 parser is explicitly compatible with VC6 and uses a syntax that is convenient to manage.
This config type will be used for accessing and setting config values.
In the D2HD releases, INI config was the format for configs before the change to JSON. Due to being bundled with Windows, it can be used as in case the user prefers it.
Replacement is to use the standard writer with the default config passed in.
Adding extra quotes causes the parser to interpret quoted strings incorrectly.
frozen does not appear to be capable of handling whitespace in JSON keys. cJSON might be reconsidered and this commit may be reverted.
When Cel File config is added, it will use a different suffix.
JSON seems to prefer keys in camelCase, while INI files have more flexibility.
This reverts commit 01464fc.
This change should allow users to realize there is a 856x480 resolution and also prompt them to switch the reoslution to 1068x600.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes rewrite the user config code to be C89 and VC6 compatible. The JSON parser is replaced with frozen, and the INI user config parser is added.
This is a requirement of #50.