Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libfswatch] New port #22527

Closed
wants to merge 32 commits into from
Closed

[libfswatch] New port #22527

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f63e8fb
[ports/libfswatch/{portfile.cmake,vcpkg.json}] Init
SamuelMarks Jan 13, 2022
12f1f31
[ports/libfswatch/vcpkg.json] Add dependencies
SamuelMarks Jan 14, 2022
780436d
./vcpkg x-add-version --all --overwrite-version
SamuelMarks Jan 14, 2022
034a3d9
[ports/libfswatch/portfile.cmake] Switch to new functions; [ports/lib…
SamuelMarks Jan 14, 2022
1e0d4ad
[ports/libfswatch/vcpkg.json] version -> version-string
SamuelMarks Jan 14, 2022
90d1d50
[ports/libfswatch/vcpkg.json] quote var
SamuelMarks Jan 14, 2022
df12d92
[ports/libfswatch/vcpkg.json] quote vars
SamuelMarks Jan 14, 2022
58958a6
[ports/libfswatch/portfile.cmake] Upgrade repo version; [ports/libfsw…
SamuelMarks Jan 15, 2022
07b87d8
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 15, 2022
4898498
[ports/libfswatch/portfile.cmake] Upgrade repo version with iconv fix…
SamuelMarks Jan 15, 2022
f00ad83
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 15, 2022
660b25e
[ports/libfswatch/portfile.cmake] Upgrade repo version with various c…
SamuelMarks Jan 15, 2022
0a63fc2
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 15, 2022
bb99933
[ports/libfswatch/portfile.cmake] Upgrade repo version with various c…
SamuelMarks Jan 16, 2022
ca7c0ed
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 16, 2022
ad7fdaa
[ports/libfswatch/portfile.cmake] Upgrade to multi-CMakeLists.txt ver…
SamuelMarks Jan 17, 2022
55d3f2c
`vcpkg x-add-version --all`
SamuelMarks Jan 17, 2022
49e8c38
[ports/libfswatch/portfile.cmake] Upgrade libfswatch version which di…
SamuelMarks Jan 18, 2022
7531eb7
`vcpkg x-add-version --all --overwrite-version`
SamuelMarks Jan 18, 2022
2770c98
[ports/libfswatch/portfile.cmake] Upgrade to macOS and Linux compatib…
SamuelMarks Jan 18, 2022
4a10b41
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 18, 2022
629f248
[ports/libfswatch/vcpkg.json] Remove "supports" key to display CI logs
SamuelMarks Jan 18, 2022
dae04d6
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 18, 2022
2a1b905
[ports/libfswatch/vcpkg.json] "supports": "!(uwp | (windows & arm))"
SamuelMarks Jan 19, 2022
d50f7a5
[versions/l-/libfswatch.json] ./vcpkg x-add-version --all --overwrite…
SamuelMarks Jan 19, 2022
c578a4e
Test with: [ports/libfswatch/vcpkg.json] supports: !uwp
SamuelMarks Jan 19, 2022
e532699
`vcpkg x-add-version --all --overwrite-version`
SamuelMarks Jan 19, 2022
583e853
[ports/libfswatch/portfile.cmake] Upgrade to latest version (which ac…
SamuelMarks Feb 5, 2022
e37e8ac
[versions/l-/libfswatch.json] `./vcpkg x-add-version --all --overwrit…
SamuelMarks Feb 5, 2022
db5a4fd
[ports/libfswatch/vcpkg.json] Add license
SamuelMarks Feb 5, 2022
ac06434
[versions/l-/libfswatch.json] `./vcpkg x-add-version --all --overwrit…
SamuelMarks Feb 5, 2022
2176473
Merge branch 'master' into fswatch
SamuelMarks May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ports/libfswatch/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO SamuelMarks/fswatch
REF 045f44c1c410f1f3c425e10d59c786a86401ccbd
SHA512 7333a33066b7dbf50304b405921b93229941455f70902e14162e3cc47e6822fa8cfa0ccce19bfebea73867f648fcdaeaab32ce48df9e01f4ef4149dac09b4dcb
HEAD_REF multi-os-ci
)

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
"-DBUILD_FSWATCH=OFF"
)
vcpkg_cmake_install()
file(INSTALL "${SOURCE_PATH}/COPYING"
DESTINATION "${CURRENT_PACKAGES_DIR}/share/libfswatch"
RENAME copyright)
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
endif()
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share")
27 changes: 27 additions & 0 deletions ports/libfswatch/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"name": "libfswatch",
"version": "1.17.0",
"description": "A cross-platform file change monitor with multiple backends: Apple OS X File System Events, *BSD kqueue, Solaris/Illumos File Events Notification, Linux inotify, Microsoft Windows and a stat()-based backend.",
"supports": "!uwp & (arm64 & !windows)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work on x64? And not on windows? I guess you probably mean "!uwp & !(arm64 & windows)" (I wounder why arm64 should not work).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@autoantwort / @strega-nil-ms Yeah I thought my clause was suspect (which is why I said it in plain-English). ARM64 Windows should work, the only thing I can think could be a stopper is if any of the dependencies listed in vcpkg.json don't support ARM64 Windows. UWP I think stops a lot of the internal Windows headers from working, so it's no surprise it fails there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing I can think could be a stopper is if any of the dependencies listed in vcpkg.json don't support ARM64 Windows

You don't have to care about this, simply remove the arm64 restriction.

UWP I think stops a lot of the internal Windows headers from working, so it's no surprise it fails there.

You can simply remove the supports expression and see what fails in reality

"dependencies": [
{
"name": "gettext",
"host": true,
"features": [
"tools"
]
},
{
"name": "pthreads",
"platform": "windows"
},
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
]
}
4 changes: 4 additions & 0 deletions versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3472,6 +3472,10 @@
"baseline": "0.2.0",
"port-version": 7
},
"libfswatch": {
"baseline": "1.17.0",
"port-version": 0
},
"libftdi": {
"baseline": "0.20",
"port-version": 3
Expand Down
9 changes: 9 additions & 0 deletions versions/l-/libfswatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"versions": [
{
"git-tree": "1f704edb9d11982d735998b471eb0d2a3d7ec31d",
"version": "1.17.0",
"port-version": 0
}
]
}