[libfswatch] New port #22527
[libfswatch] New port #22527
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/libfswatch/portfile.cmake
…fswatch/vcpkg.json] Add new functions as dependencies; [versions/l-/libfswatch.json] Commit accidently uncommited file from previous `--all`
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/libfswatch/vcpkg.json b/ports/libfswatch/vcpkg.json
index ce604ea..7606e23 100644
--- a/ports/libfswatch/vcpkg.json
+++ b/ports/libfswatch/vcpkg.json
@@ -3,6 +3,12 @@
"version-string": "1.17.0",
"description": "A cross-platform file change monitor with multiple backends: Apple OS X File System Events, *BSD kqueue, Solaris/Illumos File Events Notification, Linux inotify, Microsoft Windows and a stat()-based backend.",
"dependencies": [
+ "gettext",
+ "libiconv",
+ {
+ "name": "pthreads",
+ "platform": "windows"
+ },
{
"name": "vcpkg-cmake",
"host": true
@@ -10,12 +16,6 @@
{
"name": "vcpkg-cmake-config",
"host": true
- },
- "gettext",
- "libiconv",
- {
- "name": "pthreads",
- "platform": "windows"
}
]
}PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libfswatch but no changes to version or port version.
-- Version: 1.17.0
-- Old SHA: 325ca83f4d4b4c17c7ba10c4e8bd6eebd80525a1
-- New SHA: 6cb3632d5b533d39f781414f99bf26e15de00045
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
JonLiu1993
added
the
category:new-port
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/libfswatch/vcpkg.json b/ports/libfswatch/vcpkg.json
index dcbe803..3d6274c 100644
--- a/ports/libfswatch/vcpkg.json
+++ b/ports/libfswatch/vcpkg.json
@@ -3,6 +3,12 @@
"version": "1.17.0",
"description": "A cross-platform file change monitor with multiple backends: Apple OS X File System Events, *BSD kqueue, Solaris/Illumos File Events Notification, Linux inotify, Microsoft Windows and a stat()-based backend.",
"dependencies": [
+ "gettext",
+ "libiconv",
+ {
+ "name": "pthreads",
+ "platform": "windows"
+ },
{
"name": "vcpkg-cmake",
"host": true
@@ -10,12 +16,6 @@
{
"name": "vcpkg-cmake-config",
"host": true
- },
- "gettext",
- "libiconv",
- {
- "name": "pthreads",
- "platform": "windows"
}
]
}PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libfswatch but no changes to version or port version.
-- Version: 1.17.0
-- Old SHA: 325ca83f4d4b4c17c7ba10c4e8bd6eebd80525a1
-- New SHA: 538d7a5b96dac45674b2d2b66d990fd99b44fd50
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/libfswatch/vcpkg.json b/ports/libfswatch/vcpkg.json
index dcbe803..3d6274c 100644
--- a/ports/libfswatch/vcpkg.json
+++ b/ports/libfswatch/vcpkg.json
@@ -3,6 +3,12 @@
"version": "1.17.0",
"description": "A cross-platform file change monitor with multiple backends: Apple OS X File System Events, *BSD kqueue, Solaris/Illumos File Events Notification, Linux inotify, Microsoft Windows and a stat()-based backend.",
"dependencies": [
+ "gettext",
+ "libiconv",
+ {
+ "name": "pthreads",
+ "platform": "windows"
+ },
{
"name": "vcpkg-cmake",
"host": true
@@ -10,12 +16,6 @@
{
"name": "vcpkg-cmake-config",
"host": true
- },
- "gettext",
- "libiconv",
- {
- "name": "pthreads",
- "platform": "windows"
}
]
}PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libfswatch but no changes to version or port version.
-- Version: 1.17.0
-- Old SHA: 325ca83f4d4b4c17c7ba10c4e8bd6eebd80525a1
-- New SHA: 69cc498cc90868bab5c16fa93ac4d67b957ed555
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/libfswatch/vcpkg.json b/ports/libfswatch/vcpkg.json
index dcbe803..3d6274c 100644
--- a/ports/libfswatch/vcpkg.json
+++ b/ports/libfswatch/vcpkg.json
@@ -3,6 +3,12 @@
"version": "1.17.0",
"description": "A cross-platform file change monitor with multiple backends: Apple OS X File System Events, *BSD kqueue, Solaris/Illumos File Events Notification, Linux inotify, Microsoft Windows and a stat()-based backend.",
"dependencies": [
+ "gettext",
+ "libiconv",
+ {
+ "name": "pthreads",
+ "platform": "windows"
+ },
{
"name": "vcpkg-cmake",
"host": true
@@ -10,12 +16,6 @@
{
"name": "vcpkg-cmake-config",
"host": true
- },
- "gettext",
- "libiconv",
- {
- "name": "pthreads",
- "platform": "windows"
}
]
}PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libfswatch but no changes to version or port version.
-- Version: 1.17.0
-- Old SHA: 325ca83f4d4b4c17c7ba10c4e8bd6eebd80525a1
-- New SHA: 27ee2010212175339709e8a8bbe1edb8ed9d5f30
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
…atch/vcpkg.json] More granular dependencies; [versions/l-/libfswatch.json] Update
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libfswatch but no changes to version or port version.
-- Version: 1.17.0
-- Old SHA: d2f948c62caa5a1e4e685e14172fd35306947e9d
-- New SHA: d71f6c1855909cf7099abc054e7b4f0e2a764e42
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
…make install and vcpkg related improvements
…make install and vcpkg related improvements
|
@strega-nil-ms Yeah the |
JonLiu1993
removed
the
info:reviewed
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for libfswatch but no changes to version or port version.
-- Version: 1.17.0
-- Old SHA: b364979575068baa46b7403cdd8025eb71a0839a
-- New SHA: a165049fa2d23375593a7f8cbcd6918ef16fac2d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
|
@JonLiu1993 I think the CI needs to be kicked |
@SamuelMarks , I think you should consider @strega-nil-ms 's suggestion |
|
@JonLiu1993 Nah I think I can fix ARM support, the CI showed these style errors: Watch this space whilst I try and resolve them. Probably just a missing include or two, and existing includes which need guarding. |
|
Actually on second thought it's not obvious why this is failing. I was considering adding an explicit Ideas anyone? - E.g, @strega-nil-ms / @strega-nil |
…tually exports targets…)
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libfswatch/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
|
@SamuelMarks , |
|
Draft this pr because there is no response for a long time |
|
This PR has been inactive for a long time, please reopen it if there is any progress. |
Describe the pull request
What does your PR fix?
Fixes Vcpkg support (Windows package manager) emcrisostomo/fswatch#251
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
WiP
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?I am still working on this PR
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
WiP
NOTE: I am pinning this to my fork rather than the official source as its maintainer hasn't been active since June (I opened the PR adding MSVC support in November). Tried emailing him. If he merged the PR then happy to switch the pin to his repo.